[Bug]: Strange red lines in token properties editor

Open
  • Is something wrong?
#6,246 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
Half a day
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
java
Domain
desktop

Research direction

The symptom is in the Properties tab of the Edit Token dialog, and the reporter ties it to the fifesoft library update in commit 732d318f1b, so start by diffing that commit's dependency versions and finding where the Properties text area is created. Reproduce by opening any token's Edit Token dialog on the develop branch. Done means property text shows no red decoration, and empty and filled properties look the same.

Written by the indexing model from the issue text.

Description

bug
Describe the Bug

In the Properties tab of the Edit Token dialog, each property how a red line that shows up after any property text.

The display of the lines is not always consistent for empty properties, but for peoprties with values they always seem to appear.

To Reproduce
  1. Double-click any token.
  2. Head to the Properties tab.
Expected Behaviour

There should be no such decoartion in the text box.

Screenshots
image
MapTool Info

develop (732d318f1b)

Desktop

Linux Mint 22.3

Additional Context

This started since the fifesoft libraries were updated in 732d318f1b

Dominant language
Java
Stars
927
Forks
286
Avg merge
3d 17h
Merged PRs (30d)
94

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from RPTools/maptool

All issues in RPTools/maptool

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.