[Feature]: Grey Out Non-Working ALT-VBL Drawing Options

Open
  • Is something wrong?
#6,067 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
java
Domain
desktop

Research direction

The payload names no source files or tests. Start by finding where the drawing-method options (Fill, Line, X, Box) and the Cover, Hill and Pit VBL types are defined in the MapTool client. Decide how a selected topology should disable incompatible options, including the multi-select case the issue raises. Done means the options grey out correctly for single and combined selections, and the behaviour is confirmed by running the client.

Written by the indexing model from the issue text.

Description

feature
Describe the Problem

When it comes to the many different ALT-VBL's we now have, it is too confusing trying to figure out which drawing type is needed for them to work correctly. Some BL's simply don't work if we select the wrong drawing method (Fill, Line, X or Box).

Image

I think we can improve on this to help eliminate confusion.

The Solution you'd like

Grey out the drawing methods that simply won't work for the selected BL. Cover, Hill and Pit only work with fill, so grey out the other ones to remove that confusion that comes with over analysis.

Example:

Image

The Wiki States only these 3 BL's having limitations:
Draw a hill VBL: this VBL will simulate the effect of an increased elevation level. Works only with the solid drawing tools.
Draw a pit VBL: this VBL will simulate the effect of an decreased elevation level. Works only with the solid drawing tools.
Draw cover VBL: this VBL will simulate the effect of shrubbery, fog, or other concealing effects. Works only with the solid drawing tools.

So how would that work when multi-selecting BL's to make a Franken-BL? Well, I guess if at least 1 of the above 3 are selected then the Franken-BL should have the non-fill options grayed out.

The idea here is to make it a lot less confusing for the user, especially new ones. This is one of the biggest struggles I have with the many different Topology options we now have - it hurts my brain.

Alternatives that you've considered.

No response

Additional Context

No response

Dominant language
Java
Stars
927
Forks
286
Avg merge
3d 17h
Merged PRs (30d)
94

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from RPTools/maptool

All issues in RPTools/maptool

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.