[Bug]: Inaccessible repositories create excessive load time

Open
#6,034 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
java
Domain
desktop

Research direction

Start from campaign-from-file load and the campaign-properties repository list. Trace where repository retrieval is called on the load path and why an unreachable address blocks until timeout. Move that retrieval off the load path so the campaign opens first and fetch continues in the background. Done when a campaign with a bad repository address opens without a long hang, matching the expected behaviour in the issue.

Written by the indexing model from the issue text.

Description

bug
Describe the Bug

When loading a campaign from file, if the campaign has an inaccessible repository, MapTool is held up waiting for the repository retrieval to time-out. The wait time is long enough to make the user think MT has hung.

To Reproduce

Add a bad address for a repository in the campaign properties.
Open the campaign.
Load time is excessive.

Expected Behaviour

Repository retrieval should be performed in the background when the campaign has been loaded from file.

Screenshots

No response

MapTool Info

No response

Desktop

No response

Additional Context

No response

Dominant language
Java
Stars
927
Forks
286
Avg merge
3d 17h
Merged PRs (30d)
94

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from RPTools/maptool

All issues in RPTools/maptool

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.