Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

fix: two more 'services stop' hints print a command without --yes

Open Beginner friendly
  • Is something wrong?
#617 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
Under an hour
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
rust
Domain
cli

Research direction

Start at the two printed hints: the rocm services stop {} message near apps/rocm/src/main.rs:7210 and the {remote_cli} services stop {service_id} message near apps/rocm/src/remote/mod.rs:732. Compare them with the approval gate in run_approved_service_action and the canonical form asserted in service_actions_require_yes_and_render_sandbox_result. Done when both hints include --yes and the existing tests at main.rs:30676 and remote/mod.rs:1545 are tightened to check the full command.

Written by the indexing model from the issue text.

Description

bug

Bug

Two more places print a rocm services stop <id> hint without --yes, the same drift #417 and #601 fixed in the serve summary's stop row. run_approved_service_action refuses any stop/restart that omits --yes, so both of these teach a command the CLI then rejects:

  • apps/rocm/src/main.rs:7210 — the "already running without auth" bail message tells the user to stop it with rocm services stop {} (no --yes).
  • apps/rocm/src/remote/mod.rs:732 — the "reused service" bail message tells the user to run {remote_cli} services stop {service_id} (no --yes).

Both are real, user-facing instances of the same bug class identified during review of #601. Their existing tests (main.rs:30676, remote/mod.rs:1545) only check a substring of the message, so neither would catch this.

Suggested fix

Same minimal fix as #601: add --yes to both printed hints, matching the canonical form service_actions_require_yes_and_render_sandbox_result already asserts the approval gate recommends.

#601 also raised a related non-blocking suggestion: the stop/restart hint is currently formatted by hand in at least eight call sites across main.rs and remote/mod.rs. A shared stop_hint(service_id) / restart_hint(service_id) helper, in the spirit of run_approved_service_action's own advice already being derived from the same value the branch is taken on, would prevent this class of drift going forward rather than only fixing today's two instances.

References

  • #417 (original serve-summary drift)
  • #601 (serve-summary fix; surfaced these two during review)
Dominant language
Rust
Stars
41
Forks
10
Avg merge
5d 3h
Merged PRs (30d)
87

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ROCm/rocm-cli

All issues in ROCm/rocm-cli

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.