diagnose: a line reading "blacklistamdgpu" is treated as blacklisting amdgpu
Maintainers usually reply within 2 days
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
Research direction
Start at the line_blacklists_amdgpu function and read the doc comment describing the documented blacklist grammar. Verify the existing behavior with a line containing no whitespace after blacklist, then confirm that only lines matching the documented shape are reported by rocm diagnose.
Written by the indexing model from the issue text.
Description
Current behavior
line_blacklists_amdgpu strips the blacklist prefix and then trims leading whitespace, so it never requires any whitespace between the directive and the module name:
line_blacklists_amdgpu("blacklistamdgpu") -> true
modprobe does not treat that line as a directive, so nothing is blacklisted — but rocm diagnose reports amdgpu_blacklisted_in for that file.
Expected behavior
Matches the contract the function's own doc comment states, ^\s*blacklist\s+amdgpu\b, where \s+ requires at least one whitespace character.
Steps to reproduce
Put a line reading exactly blacklistamdgpu in a file under /etc/modprobe.d/ and run rocm diagnose.
Consequence
The diagnosis points at a non-cause. A user is told to un-blacklist a module that was never blacklisted, while whatever actually prevented the driver loading goes unreported.
Possible solution
Require whitespace after the directive. The doc comment one line above already states the intended grammar; the code is the side that disagrees.
Environment
- Built from
main. Pure text parsing, platform-independent.
Additional context
Found by property-testing the modprobe grammar — the property asserted that a line only reports a blacklist when it matches the documented shape. Pre-existing; unrelated to any in-flight change, which is why it is filed separately rather than folded into one.
- Dominant language
- Rust
- Stars
- 41
- Forks
- 10
- Avg merge
- 5d 14h
- Merged PRs (30d)
- 87
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ROCm/rocm-cli
-
Move the remaining `scripts/` tooling to Rust (`cargo xtask` / e2e scenarios)Possibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 2 days
-
serve: the post-launch smoke test spins forever at 100% CPU if the engine closes the connection mid-responsePossibly taken @rominf claimed this 3 days ago. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
ROCm/rocm-cli#514 · 1 comment ·
Maintainers usually reply within 2 days
-
examine: lspci cannot name a GPU that pci.ids does not know, though the device id is on the lineOpenbug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 2 days
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 2 days
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Maintainers usually reply within 2 days
Similar issues
-
agent:triaged bug bughunt pm:npm priority:p1
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
SocketDev/socket-patch#1127 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
documentation enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
adorsys/status-list-server#619 ·
Maintainers usually reply within 2 days
-
batch-backport only backports the first 30 matching PRsPossibly taken @DvirDukhan claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 5 days
-
Configuration-level resource: `Allocate` rejects the kubelet's re-offer of the same device for a later container of the same Pod ("Unable to claim slot")Possibly taken @fang80913 claimed this 38 days ago. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
project-akri/akri#854 ·