Server: `min_p` is read as `int`, so fractional values (e.g. `0.05`) become 0
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 88/100
Research direction
In src/server/rest_handler.cpp, inspect configure_chat_engine_parameters around the min_p handling and compare it with the temperature and top_p parsing nearby. The issue identifies the expected type change and notes that set_minp accepts a float; verify the server API preserves a value such as 0.05, then check whether an existing test covers this request parameter.
Written by the indexing model from the issue text.
Description
In configure_chat_engine_parameters (src/server/rest_handler.cpp, lines 814-816 at tag v1.0.11; same on main as of 2026-10-31):
if (has_value(request, "min_p")) {
int min_p = request["min_p"];
auto_chat_engine->set_minp(min_p);
}
set_minp takes a float (src/include/AutoModel/automodel.hpp:509), and the flm run path parses the value with std::stof (src/runner/runner.cpp:600). Because of the int, a usual value such as "min_p": 0.05 is truncated to 0 before it reaches the sampler, so min_p has no effect through the server API. In the same function, temperature and top_p are read as float.
Expected: float min_p = request["min_p"];
Found by reading the source; not checked at runtime.
- Dominant language
- C++
- Stars
- 2k
- Forks
- 170
- Avg merge
- 16h 2m
- Merged PRs (30d)
- 102
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ROCm/FastFlowLM
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
ROCm/FastFlowLM#757 ·
Maintainers usually reply within 1 day
-
No valid checkpoint to restore + Max length reached on multi-turn tool calls (Qwen3.6-MoE, NPU)Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
ROCm/FastFlowLM#744 · 2 comments ·
Maintainers usually reply within 1 day
-
Truncated tool call is emitted as a complete one (unterminated heredoc reaches the client)Possibly taken @Javinator9889 claimed this 45 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
ROCm/FastFlowLM#741 · 1 comment ·
Maintainers usually reply within 1 day
-
Download timeoutPossibly taken @stdevPavelmc claimed this 172 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
ROCm/FastFlowLM#520 · 7 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
ROCm/FastFlowLM#434 · 1 comment ·
Maintainers usually reply within 1 day
Similar issues
-
devex good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
artifact:simulation-scenario domain:physics good first issue help wanted role:validation testing
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 3 days
-
[BUG] `mx.qqmm` docs: the Args section names `global_scale`, but the parameter is `global_scale_x`Possibly taken @Redempt1onzzZZ claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 92/100
ml-explore/mlx#4815 ·
Maintainers usually reply within 2 days
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day