Download timeout

Open Beginner friendly
#520 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
74/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
cpp
Domain
networking

Research direction

Start at src/pull/download_model.cpp:160 and inspect how the download request configures its one-hour timeout. Determine whether the timeout should be removed or made configurable, then verify that a model download can continue beyond one hour without failing due to the hard-coded limit.

Written by the indexing model from the issue text.

Description

I am at a very slow internet connection and downloading almost any model gives me a timeout:

[FLM]  Downloading 2/7: model.q4nx
[FLM]  Downloading: 86.0% (3830.0MB / 4455.4MB)CURL error: Timeout was reached

Currently there is a hard-coded timeout of one hour set here

https://github.com/FastFlowLM/FastFlowLM/blob/bb309ad60ac37daddf4ac81723925d72dd251b60/src/pull/download_model.cpp#L160

I suggest removing this limitation, I think this can be done to setting the limit to 0, alternatively you could make it configurable.

Edit: Just as a reference, a 10Mbit connection can download just over 4 GB/h and a 4B sized model is just around that limit.

Dominant language
C++
Stars
1.9k
Forks
152
Avg merge
4h 14m
Merged PRs (30d)
11

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ROCm/FastFlowLM

All issues in ROCm/FastFlowLM

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.