toLocaleString bug formatting currencies in Spanish

Open
#3,114 0 comments 0 reactions 1 assignee View on GitHub

Maintainers usually reply within 1 day

@jorgeatgu is already working on this.

Since Jul 21, 2020.

Assessment

This issue has not been assessed yet.

Description

bug

We are using toLocaleString to handle number formatting to strings in several places and it seems that this is the way the browser JS engine handles the Spanish locales:

Captura de pantalla 2020-05-27 a las 14 31 52

It only happens with numbers from 1000 to 9999. 10000 is properly formatted to 10.000.

It's kind of recent.

More information: https://stackoverflow.com/questions/57628055/tolocalestring-not-working-on-numbers-less-than-10000-in-all-browsers

Dominant language
Ruby
Stars
79
Forks
31
Avg merge
2d 1h
Merged PRs (30d)
23

Getting set up

  • Ships a Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PopulateTools/gobierto

All issues in PopulateTools/gobierto

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.