SQLEditorResults does know nothing about what Visualizations does
Maintainers usually reply within 1 day
@jorgeatgu is already working on this.
Since May 5, 2020.
Assessment
This issue has not been assessed yet.
Description
What are this Visualizations functions doing enclosed here? You're messing with the logic. SQLEditorResults does know nothing about what Visualizations does. The parent just "inform" the children about showing/hiding, nothing else.
These functions does not belong here.
Originally posted by @Crashillo in https://github.com/PopulateTools/gobierto/diffs
UPDATE: original discussion is https://github.com/PopulateTools/gobierto/pull/3005#discussion_r415649462
- Dominant language
- Ruby
- Stars
- 79
- Forks
- 31
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 23
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from PopulateTools/gobierto
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
PopulateTools/gobierto#4436 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 30/100
PopulateTools/gobierto#4435 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
PopulateTools/gobierto#4430 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 45/100
PopulateTools/gobierto#4311 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 25/100
PopulateTools/gobierto#4081 ·
Maintainers usually reply within 1 day
All issues in PopulateTools/gobierto
Similar issues
-
Bug Ruby
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
getsentry/sentry-ruby#3211 · 1 comment ·
Maintainers usually reply within 2 days
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
internetee/registry#2984 ·
Maintainers usually reply within 6 days
-
interest-zsv
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
hitobito/hitobito_zsv#6 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
ecosyste-ms/issues#862 ·
Maintainers usually reply within 1 day
-
Redis Lua error `@user_script:52: ERR value is not an integer or out of range` when `window_size` is configuredPossibly taken @mimosa claimed this today. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day