SQLEditorResults does know nothing about what Visualizations does

Open
#3,023 1 comment 0 reactions 1 assignee View on GitHub

Maintainers usually reply within 1 day

@jorgeatgu is already working on this.

Since May 5, 2020.

Assessment

This issue has not been assessed yet.

Description

What are this Visualizations functions doing enclosed here? You're messing with the logic. SQLEditorResults does know nothing about what Visualizations does. The parent just "inform" the children about showing/hiding, nothing else.
These functions does not belong here.

Originally posted by @Crashillo in https://github.com/PopulateTools/gobierto/diffs

UPDATE: original discussion is https://github.com/PopulateTools/gobierto/pull/3005#discussion_r415649462

Dominant language
Ruby
Stars
79
Forks
31
Avg merge
2d 1h
Merged PRs (30d)
23

Getting set up

  • Ships a Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PopulateTools/gobierto

All issues in PopulateTools/gobierto

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.