[cmake] QHULL/FLANN dll missing when linking single module
Maintainers usually reply within 3 days
Assessment
- Difficulty
- 3/5
- Estimated time
- Half a day
- Newbie friendliness
- 50/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- cmake, cpp
- Domain
- build-system
Research direction
The dependency edge is built in PCLConfig.cmake.in inside find_external_library(), which only attaches an external library when the legacy ${LIB}_LIBRARIES variable is set. Compare that with cmake/Modules/FindQhull.cmake and cmake/Modules/FindFLANN.cmake, which create QHULL::QHULL and FLANN::FLANN targets without setting those variables. Done when $<TARGET_RUNTIME_DLLS:app> for an app linking pcl_surface includes qhull_r.dll and flann_cpp.dll. Verifying that needs a shared Windows build.
Written by the indexing model from the issue text.
Description
Describe the bug
Linking pcl_surface instead of the legacy ${PCL_LIBRARIES} does not declare PCL's external
dependencies, so $<TARGET_RUNTIME_DLLS> omits qhull_r.dll (imported by pcl_surface.dll) and
flann_cpp.dll (imported by pcl_kdtree.dll). A deployed application then exits with
0xC0000135 (STATUS_DLL_NOT_FOUND).
Expected behavior
$<TARGET_RUNTIME_DLLS:app> contains qhull_r.dll and flann_cpp.dll when app links
pcl_surface.
Current Behavior
PCLConfig.cmake.in (master) attaches an external dependency to a component only through the
legacy variable:
# find_external_library(), L343-347
if(${LIB}_LIBRARIES)
list(APPEND PCL_${COMPONENT}_LINK_LIBRARIES "${${LIB}_LIBRARIES}")
...
endif()
cmake/Modules/FindQhull.cmake (L45–81) and FindFLANN.cmake (L45–91) create
QHULL::QHULL / FLANN::FLANN and return() without setting QHULL_LIBRARIES /
FLANN_LIBRARIES. The fallback at L766–771 only feeds ${PCL_LIBRARIES}.
Measured with PCL 1.14.1 shared, WITH_QHULL=ON, FLANN on:
pcl_surface INTERFACE_LINK_LIBRARIES = [OpenMP::OpenMP_CXX;pcl_common;pcl_search;pcl_kdtree;pcl_octree]
$<TARGET_RUNTIME_DLLS:app> = 10 DLLs, no qhull_r.dll, no flann_cpp.dll
app.exe = exit -1073741515 (0xC0000135)
The same file already does this for Eigen3 (L128–131) and OpenMP (L316–319), so this looks like
an omission.
To Reproduce
cmake_minimum_required(VERSION 3.21)
project(pcl_external_deps_repro LANGUAGES CXX)
set(CMAKE_CXX_STANDARD 17)
find_package(PCL REQUIRED COMPONENTS surface)
add_executable(app main.cpp)
target_link_libraries(app PRIVATE pcl_surface)
file(GENERATE OUTPUT "${CMAKE_BINARY_DIR}/dlls_$<CONFIG>.txt"
CONTENT "$<JOIN:$<TARGET_RUNTIME_DLLS:app>,|>")
#include <pcl/point_cloud.h>
#include <pcl/point_types.h>
#include <pcl/surface/mls.h>
int main()
{
pcl::MovingLeastSquares<pcl::PointXYZ, pcl::PointXYZ> mls;
pcl::PointCloud<pcl::PointXYZ> cloud;
cloud.push_back(pcl::PointXYZ(0.0f, 0.0f, 0.0f));
cloud.push_back(pcl::PointXYZ(1.0f, 0.0f, 0.0f));
cloud.push_back(pcl::PointXYZ(0.0f, 1.0f, 0.0f));
pcl::PointCloud<pcl::PointXYZ> output;
mls.setInputCloud(cloud.makeShared());
mls.process(output);
return 0;
}
Build Release, copy app.exe and only the DLLs listed in dlls_Release.txt into an empty
folder, run app.exe → exit -1073741515 (0xC0000135). Adding qhull_r.dll alone still
fails; adding qhull_r.dll and flann_cpp.dll makes it run.
Environment
Windows 10 x64, MSVC 19.44, CMake 3.21+, PCL 1.14.1 (shared, WITH_QHULL=ON, FLANN on),
Qhull 8.x with modern QhullConfig.cmake. Code checked on master.
Possible Solution
Append one branch to the block at L340–347:
if(${LIB}_LIBRARIES)
list(APPEND PCL_${COMPONENT}_LINK_LIBRARIES "${${LIB}_LIBRARIES}")
set(PCL_${COMPONENT}_LINK_LIBRARIES ${PCL_${COMPONENT}_LINK_LIBRARIES} PARENT_SCOPE)
set(PCL_${LIB}_LIBRARIES ${${LIB}_LIBRARIES} PARENT_SCOPE) # Later appended to PCL_LIBRARIES
elseif(TARGET ${LIB}::${LIB})
list(APPEND PCL_${COMPONENT}_LINK_LIBRARIES ${LIB}::${LIB})
set(PCL_${COMPONENT}_LINK_LIBRARIES ${PCL_${COMPONENT}_LINK_LIBRARIES} PARENT_SCOPE)
set(PCL_${LIB}_LIBRARIES ${LIB}::${LIB} PARENT_SCOPE)
endif()
QHULL::QHULL and FLANN::FLANN match ${LIB}::${LIB}; VTK / Boost / Eigen3 / OpenMP keep
taking the first branch. With this patch the interface becomes
[QHULL::QHULL;OpenMP::OpenMP_CXX;FLANN::FLANN;pcl_common;...], the closure grows 10 → 12 DLLs,
and app.exe runs.
Additional context
#6345 / #6410 were about wrong DLL paths; here the paths are correct and the dependency edge
is missing. Related: #5108, #2581.
- Dominant language
- C++
- Stars
- 11.2k
- Forks
- 4.7k
- Avg merge
- 6d 13h
- Merged PRs (30d)
- 10
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from PointCloudLibrary/pcl
-
kind: bug status: triage
Difficulty 1/5 Under an hour Newbie friendliness 82/100
PointCloudLibrary/pcl#6536 ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
PointCloudLibrary/pcl#6509 · 1 comment ·
Maintainers usually reply within 3 days
-
kind: bug status: triage
Difficulty 4/5 3-5 days Newbie friendliness 48/100
PointCloudLibrary/pcl#6537 ·
Maintainers usually reply within 3 days
-
kind: bug status: triage
Difficulty 4/5 3-5 days Newbie friendliness 35/100
PointCloudLibrary/pcl#6395 ·
Maintainers usually reply within 3 days
-
[sample_consensus] Migrated the SSE and AVX implementations of countWithinDistance to RISC-V RVV 1.0Openkind: request status: triage
Difficulty 5/5 Over a week Newbie friendliness 25/100
PointCloudLibrary/pcl#6385 · 1 reaction ·
Maintainers usually reply within 3 days
All issues in PointCloudLibrary/pcl
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
nextcloud/passman-android#214 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
feature wsl2
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
microsoft/WSL#42306 · 3 comments ·
Maintainers usually reply within 1 day
-
2026.11.0 fails to install on Intel macOS: requirements.txt pins cryptography==50.0.2 for Darwin x86_64May be free again A pull request for this issue was closed without being merged. Open
Difficulty 1/5 Under an hour Newbie friendliness 87/100
esphome/esphome#22892 · 1 comment ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
distante/esphome-components#50 · 1 comment ·
Maintainers usually reply within 1 day