[cmake] QHULL/FLANN dll missing when linking single module

未关闭
#6,522 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 3 天内回复

@SIDDARTHAREDDY8 已经在做这个了。

开始于 2026年11月13日。

  • #6526 来自 @SIDDARTHAREDDY8 —— 未关闭

评估

难度
3/5
预计耗时
半天
新手友好度
50/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
cmake, cpp
领域
build-system

调研方向

The dependency edge is built in PCLConfig.cmake.in inside find_external_library(), which only attaches an external library when the legacy ${LIB}_LIBRARIES variable is set. Compare that with cmake/Modules/FindQhull.cmake and cmake/Modules/FindFLANN.cmake, which create QHULL::QHULL and FLANN::FLANN targets without setting those variables. Done when $<TARGET_RUNTIME_DLLS:app> for an app linking pcl_surface includes qhull_r.dll and flann_cpp.dll. Verifying that needs a shared Windows build.

由索引模型根据 Issue 内容生成。

描述

kind: bug module: cmake

Describe the bug

Linking pcl_surface instead of the legacy ${PCL_LIBRARIES} does not declare PCL's external
dependencies, so $<TARGET_RUNTIME_DLLS> omits qhull_r.dll (imported by pcl_surface.dll) and
flann_cpp.dll (imported by pcl_kdtree.dll). A deployed application then exits with
0xC0000135 (STATUS_DLL_NOT_FOUND).

Expected behavior

$<TARGET_RUNTIME_DLLS:app> contains qhull_r.dll and flann_cpp.dll when app links
pcl_surface.

Current Behavior

PCLConfig.cmake.in (master) attaches an external dependency to a component only through the
legacy variable:

# find_external_library(), L343-347
if(${LIB}_LIBRARIES)
  list(APPEND PCL_${COMPONENT}_LINK_LIBRARIES "${${LIB}_LIBRARIES}")
  ...
endif()

cmake/Modules/FindQhull.cmake (L45–81) and FindFLANN.cmake (L45–91) create
QHULL::QHULL / FLANN::FLANN and return() without setting QHULL_LIBRARIES /
FLANN_LIBRARIES. The fallback at L766–771 only feeds ${PCL_LIBRARIES}.

Measured with PCL 1.14.1 shared, WITH_QHULL=ON, FLANN on:

pcl_surface INTERFACE_LINK_LIBRARIES = [OpenMP::OpenMP_CXX;pcl_common;pcl_search;pcl_kdtree;pcl_octree]
$<TARGET_RUNTIME_DLLS:app>           = 10 DLLs, no qhull_r.dll, no flann_cpp.dll
app.exe                              = exit -1073741515 (0xC0000135)

The same file already does this for Eigen3 (L128–131) and OpenMP (L316–319), so this looks like
an omission.

To Reproduce

cmake_minimum_required(VERSION 3.21)
project(pcl_external_deps_repro LANGUAGES CXX)
set(CMAKE_CXX_STANDARD 17)

find_package(PCL REQUIRED COMPONENTS surface)

add_executable(app main.cpp)
target_link_libraries(app PRIVATE pcl_surface)

file(GENERATE OUTPUT "${CMAKE_BINARY_DIR}/dlls_$<CONFIG>.txt"
     CONTENT "$<JOIN:$<TARGET_RUNTIME_DLLS:app>,|>")
#include <pcl/point_cloud.h>
#include <pcl/point_types.h>
#include <pcl/surface/mls.h>

int main()
{
    pcl::MovingLeastSquares<pcl::PointXYZ, pcl::PointXYZ> mls;
    pcl::PointCloud<pcl::PointXYZ> cloud;
    cloud.push_back(pcl::PointXYZ(0.0f, 0.0f, 0.0f));
    cloud.push_back(pcl::PointXYZ(1.0f, 0.0f, 0.0f));
    cloud.push_back(pcl::PointXYZ(0.0f, 1.0f, 0.0f));

    pcl::PointCloud<pcl::PointXYZ> output;
    mls.setInputCloud(cloud.makeShared());
    mls.process(output);
    return 0;
}

Build Release, copy app.exe and only the DLLs listed in dlls_Release.txt into an empty
folder, run app.exe → exit -1073741515 (0xC0000135). Adding qhull_r.dll alone still
fails; adding qhull_r.dll and flann_cpp.dll makes it run.

Environment

Windows 10 x64, MSVC 19.44, CMake 3.21+, PCL 1.14.1 (shared, WITH_QHULL=ON, FLANN on),
Qhull 8.x with modern QhullConfig.cmake. Code checked on master.

Possible Solution

Append one branch to the block at L340–347:

    if(${LIB}_LIBRARIES)
      list(APPEND PCL_${COMPONENT}_LINK_LIBRARIES "${${LIB}_LIBRARIES}")
      set(PCL_${COMPONENT}_LINK_LIBRARIES ${PCL_${COMPONENT}_LINK_LIBRARIES} PARENT_SCOPE)
      set(PCL_${LIB}_LIBRARIES ${${LIB}_LIBRARIES} PARENT_SCOPE) # Later appended to PCL_LIBRARIES
    elseif(TARGET ${LIB}::${LIB})
      list(APPEND PCL_${COMPONENT}_LINK_LIBRARIES ${LIB}::${LIB})
      set(PCL_${COMPONENT}_LINK_LIBRARIES ${PCL_${COMPONENT}_LINK_LIBRARIES} PARENT_SCOPE)
      set(PCL_${LIB}_LIBRARIES ${LIB}::${LIB} PARENT_SCOPE)
    endif()

QHULL::QHULL and FLANN::FLANN match ${LIB}::${LIB}; VTK / Boost / Eigen3 / OpenMP keep
taking the first branch. With this patch the interface becomes
[QHULL::QHULL;OpenMP::OpenMP_CXX;FLANN::FLANN;pcl_common;...], the closure grows 10 → 12 DLLs,
and app.exe runs.

Additional context

#6345 / #6410 were about wrong DLL paths; here the paths are correct and the dependency edge
is missing. Related: #5108, #2581.

主要语言
C++
星标
11.2k
派生
4.7k
平均合并
6 天 13 小时
30 天内合并 PR
10

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

PointCloudLibrary/pcl 的其他 Issue

查看 PointCloudLibrary/pcl 的全部 Issue

相似的 Issue

更多 C++ Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。