[pcl_visualizer] "Allow custom definition of non-dense point cloud"
Maintainers usually reply within 3 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 38/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- cpp
- Domain
- computer-vision, performance
Research direction
Start by tracing updatePointCloud() and addPointCloud() to convertPointCloudToVTKPolyData(), where point validity is currently checked with three std::isfinite calls. Determine how a custom invalid-point definition could be exposed while preserving the existing behavior by default; done means both conversion paths support the requested customization without breaking non-dense point-cloud handling.
Written by the indexing model from the issue text.
Description
When profiling, it seems that quite some time is being used to test if each point in a point cloud is valid. Of course, this is necessary for non-dense point clouds. However, it could be done faster.
This happens when calling updatePointCloud() and addPointCloud() which both calls convertPointCloudToVTKPolyData().
Then function tests non-density with
// Check if the point is invalid
if (!std::isfinite ((*cloud)[i].x) ||
!std::isfinite ((*cloud)[i].y) ||
!std::isfinite ((*cloud)[i].z))
continue;
Here it would be useful to be able to inject a custom definition:
// Check if the point is invalid
if ( isInvalidPoint((*cloud)[i]) )
continue;
For example, it may be enough for certain applications to test if the x-component is NaN to determine this. Today we get 3 tests per point and each may results in a non-inlined function call.
The downside is that each of the above three functions needs an additional template parameter.
I hope it is something that you will consider in the future.
kind regards
Thorsten
- Dominant language
- C++
- Stars
- 11.2k
- Forks
- 4.7k
- Avg merge
- 6d 13h
- Merged PRs (30d)
- 10
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from PointCloudLibrary/pcl
-
kind: bug status: triage
Difficulty 1/5 Under an hour Newbie friendliness 82/100
PointCloudLibrary/pcl#6536 ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
PointCloudLibrary/pcl#6509 · 1 comment ·
Maintainers usually reply within 3 days
-
kind: bug status: triage
Difficulty 4/5 3-5 days Newbie friendliness 48/100
PointCloudLibrary/pcl#6537 ·
Maintainers usually reply within 3 days
-
[cmake] QHULL/FLANN dll missing when linking single modulePossibly taken @SIDDARTHAREDDY8 claimed this 6 days ago. Openkind: bug module: cmake
Difficulty 3/5 Half a day Newbie friendliness 50/100
PointCloudLibrary/pcl#6522 · 1 comment ·
Maintainers usually reply within 3 days
-
kind: bug status: triage
Difficulty 4/5 3-5 days Newbie friendliness 35/100
PointCloudLibrary/pcl#6395 ·
Maintainers usually reply within 3 days
All issues in PointCloudLibrary/pcl
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
nextcloud/passman-android#214 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
feature wsl2
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
microsoft/WSL#42306 · 3 comments ·
Maintainers usually reply within 1 day
-
2026.11.0 fails to install on Intel macOS: requirements.txt pins cryptography==50.0.2 for Darwin x86_64May be free again A pull request for this issue was closed without being merged. Open
Difficulty 1/5 Under an hour Newbie friendliness 87/100
esphome/esphome#22892 · 1 comment ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
distante/esphome-components#50 · 1 comment ·
Maintainers usually reply within 1 day