[Registration] PCL-NDT codes calculate gauss_c1, c2 may have problem? equation 6.7

Open
#5,574 2 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 3 days

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
cpp

Research direction

Start with the gauss_c1 and gauss_c2 definitions in ndt.hpp and compare them with equation 6.7/6.8 in Magnusson's 2009 thesis. Review related issue #5056 and the linked discussion to determine whether the implementation is incorrect or the question reflects a notation difference. Done means establishing the intended formula and documenting or reporting a concrete correction if needed.

Written by the indexing model from the issue text.

Description

module: registration status: triage

My confusion:

Paper: 2009 Phd Thesis <The Three-Dimensional Normal-Distributions Transform>

Equation here:
enter image description here

Code here:

   // Initializes the gaussian fitting parameters (eq. 6.8) [Magnusson 2009]
   const double gauss_c1 = 10.0 * (1 - outlier_ratio_);
   const double gauss_c2 = outlier_ratio_ / pow(resolution_, 3);

Question:
Why the PCL code write the constant c1, c2 as, pcl source code link:

Why the c1, c2 could be formulated as the codes said, and why 10 times on c1 also?


Other related issues to understand more:

  1. https://github.com/PointCloudLibrary/pcl/issues/5056
  2. same question in StackOverflow: https://stackoverflow.com/questions/75057084/normal-distributions-transform-pcl-ndt-codes-calculate-c1-c2-may-have-problem
Dominant language
C++
Stars
11.2k
Forks
4.7k
Avg merge
6d 13h
Merged PRs (30d)
10

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PointCloudLibrary/pcl

All issues in PointCloudLibrary/pcl

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.