Add minimal mineral N cycle

Open
  • Is something wrong?
#88 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 2 days

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
30/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
c
Domain
backend

Research direction

The issue gives the target equation for dN_min/dt, taken from the model structure documentation (eq 15), and asks for only the fertilizer input, volatilization and leaching terms. Read that documentation section first to confirm how each flux term is defined. The payload names no source files, so locate the existing soil nitrogen or carbon pool updates in the C code yourself. Done means the N pool is updated, the docs and changelog are revised, and tests cover the new terms.

Written by the indexing model from the issue text.

Description

MAGiC N cycle

Starting with eq 15 specified in the model structure documentation:

$$
\frac{dN_\text{min}}{{dt}} =
F^N_\text{litter,min} +
F^N_\text{soil,min} +
F^N_\text{fix} +
F^N_\text{fert,min} -
F^N_\mathrm{vol} -
F^N_\text{leach} -
F^N_\text{uptake}
$$

The first step is to implement the core mineral N cycle, i.e.

$$
\frac{dN_\text{min}}{{dt}} =
F^N_\text{fert,min} -
F^N_\mathrm{vol} -
F^N_\text{leach}
$$

Each pull request should include

  • updated documentation
  • tests for new feature
  • updated changelog
Dominant language
C
Stars
42
Forks
38
Avg merge
3d 21h
Merged PRs (30d)
10

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PecanProject/sipnet

All issues in PecanProject/sipnet

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.