Add `allow-time-gaps` flag

Open
#289 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 2 days

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
12/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
c
Domain
backend

Research direction

The issue is marked not yet ready and leaves the default and the climate-record approach open, so it needs a maintainer decision before coding. Find where context flags are defined and where restart time-boundary warnings and climate record checks are emitted, then confirm the intended default with maintainers. Done means the flag is parsed, the FALSE path errors and the TRUE path uses logInfo().

Written by the indexing model from the issue text.

Description

on hold

THIS TICKET IS NOT YET READY

Task:

  • Add a new context flag allow-time-gaps (default TBD)
  • When the flag is FALSE
    • For restart time boundary checks, error instead of warn
    • For climate records, do something appropriate; current candidate is to track total daily time, and make sure the time steps add to 24 hours when the day changes. This might not be sufficient if time steps are variable.
    • Also, check that we don't skip a day in the climate records
  • When the flag is TRUE
    • change restart time boundary warnings to info logs (logInfo())
    • have new climate record checks log an info message as well.
Dominant language
C
Stars
42
Forks
38
Avg merge
3d 21h
Merged PRs (30d)
10

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PecanProject/sipnet

All issues in PecanProject/sipnet

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.