Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

Drillneck: "for each time they have Pierced" modifiers are not parsed

未关闭 适合新手
  • 哪里不对？
#2,560 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 4 天内回复

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
80/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
lua
领域
data

调研方向

在 src/Modules/ModParser.lua:1681 的现有已收缩条目旁边添加未收缩键，使用相同的标签 { type = "PerStat", stat = "PiercedCount" }；src/Data/ModItemExclusive.lua 中的游戏数据字符串 UniqueProjectileIncreasedDamagePerPierce1 和 UniqueProjectileIncreasedCriticalHitChancePerPierce1 显示了要匹配的确切措辞。然后重新生成 src/Data/ModCache.lua，使残留的 " for each time they have Pierced " 后缀从 Drillneck 行中消失。通过装备 Drillneck、在 Configuration 中设置 "# of times Skill has Pierced"，并确认 DPS 和暴击几率发生变化来进行验证；ModCache.lua:6616 处相关的 "Attack Projectiles Return if they Pierced" 行不在本次范围内。

由索引模型根据 Issue 内容生成。

描述

Drillneck (Penetrating Quiver) has two per-pierce modifiers:

Projectiles deal (42-64)% increased Damage with Hits for each time they have Pierced
Projectiles have (42-64)% increased Critical Hit chance for each time they have Pierced

PoB parses the increase but not the condition, so part of each line is left unparsed and neither line is applied, whatever the pierce count is. The generated cache records the remainder:

src/Data/ModCache.lua:8996
c["Projectiles deal 64% increased Damage with Hits for each time they have Pierced"]={{[1]={flags=1024,keywordFlags=262144,name="Damage",type="INC",value=64}},"   for each time they have Pierced "}

The game-data wording is "they have Pierced" (src/Data/ModItemExclusive.lua, UniqueProjectileIncreasedDamagePerPierce1 and UniqueProjectileIncreasedCriticalHitChancePerPierce1). ModParser.lua only has the contracted form:

-- src/Modules/ModParser.lua:1681 (dev bb52d6b)
["for each time they've pierced"] = { tag = { type = "PerStat", stat = "PiercedCount" } },
Proposed fix

Add the uncontracted wording next to it, with the same tag, then regenerate ModCache.lua:

["for each time they have pierced"] = { tag = { type = "PerStat", stat = "PiercedCount" } },
Repro
  1. Equip Drillneck with a projectile skill.
  2. In Configuration, set "# of times Skill has Pierced" to 1 or 2.
  3. Damage and crit chance do not change.
Measured effect

With the two lines reworded to "they've Pierced" (which PoB parses), a Frostbolt build against the boss preset:

# of times Skill has Pierced Frostbolt DPS Crit chance
0 3,572 11.4%
1 12,660 39.1%
2 27,308 66.8%

With the item's own wording, every pierce count reads as the first row.

Not in this report

"Attack Projectiles Return if they Pierced at least (2-4) times" is also unparsed (ModCache.lua:6616). Return is a separate mechanic, so it would be a separate report.

主要语言
Lua
星标
1.9k
派生
455
平均合并
6 天 6 小时
30 天内合并 PR
25

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

PathOfBuildingCommunity/PathOfBuilding-PoE2 的其他 Issue

查看 PathOfBuildingCommunity/PathOfBuilding-PoE2 的全部 Issue

相似的 Issue

更多 Lua Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。