Note that the same-day correlation in the AR(1) example leaves out the AR(1) variance
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
- Issue type
- Documentation
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- markdown, r
- Domain
- documentation
Research direction
Start with the APIM vignette at vignettes/apim.Rmd, around lines 811–823, and rerun the calculation for the same-day residual, including the AR(1) variance. Add the suggested sentence clarifying that the same-day pair describes the residual component that does not carry over between days; done when the calculation is checked and readers will not mistake it for the whole same-day residual.
Written by the indexing model from the issue text.
Description
The APIM vignette recovers the member-level covariance from a diary model that also has AR(1) terms. See the example.
The recovered same-day matrix is correct for the dyad-day blocks. It does not include the AR(1) variance, which belongs to the same level. A reader will take the printed SD and correlation for the whole same-day residual.
In the review, the printed values were an SD of 0.835 and a correlation of 0.297. With the AR(1) variance of 0.305 included, the same-day residual SD is 1.001 and the partner correlation 0.206. I have not repeated this calculation.
Suggested fix and checks
- Re-run the calculation.
- Add one sentence after the example: the same-day pair describes the part of the residual that does not carry over between days.
- Dominant language
- R
- Stars
- 1
- Forks
- 2
- Avg merge
- 11h 4m
- Merged PRs (30d)
- 42
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Pascal-Kueng/dyadMLM
-
Add two cautions to the `simulate_dyad_responses()` helpPossibly taken A pull request linked to this issue is open or already merged. Opendocumentation priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Pascal-Kueng/dyadMLM#179 ·
Maintainers usually reply within 1 day
-
Describe the brms summaries of `recover_exchangeable_covariance()` accuratelyPossibly taken A pull request linked to this issue is open or already merged. Opendocumentation good first issue priority: low
Difficulty 1/5 1-3 hours Newbie friendliness 85/100
Pascal-Kueng/dyadMLM#177 ·
Maintainers usually reply within 1 day
-
Say where `.member_contrast_*` columns may be usedPossibly taken @Voyagerroc claimed this 1 day ago. Opendocumentation good first issue priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Pascal-Kueng/dyadMLM#175 · 1 comment ·
Maintainers usually reply within 1 day
-
bug good first issue priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Pascal-Kueng/dyadMLM#173 ·
Maintainers usually reply within 1 day
-
documentation good first issue priority: low
Difficulty 1/5 Under an hour Newbie friendliness 90/100
Pascal-Kueng/dyadMLM#171 ·
Maintainers usually reply within 1 day
All issues in Pascal-Kueng/dyadMLM
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100
cran-task-views/Spatial#127 · 1 comment ·
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Consider changesOpen
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
OHDSI/OmopSketch#618 ·