Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

disposition queue #844/#840/#728 is fully staged and approval-blocked — two cross-identity reviews unblock the train

Open
  • Is something wrong?
#854 6 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
1/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Active
Tech stack
docker, go
Domain
devops, release

Research direction

Read the linked PRs #844, #840, and #728 and the handoff at /tmp/opencode/release-week/rig-handoff-wave3.md. The stated next steps are cross-identity approvals, a one-line rebase, and outstanding rig runs: the Docker image build and tests/cloud-lab/run-crash-injection.sh. The issue says merges and validation are still pending, so this work is not complete.

Written by the indexing model from the issue text.

Description

State (all staged, nothing left to prepare)

PR head what it is closes on merge gate
#844 77064b3 global-ARG hoist in Dockerfile.client + fragment — re-lights every cloud-lab lane (client/killer images are unbuildable from scratch without it) #724 1 approving review
#840 08c015f both #834 audit halves (NUT-07 value-correlation + journal dir-fsync) + ported shortfall test #834 1 approving review
#728 0a8079d FROM-ARG scope fence, guard-only (hardened: refuses vacuous passes) — review after #844 + a one-line rebase

#843 was the duplicate sibling — closed with the disposition record; its unique test lives in #840 now. Auto-merge (squash) is queued on #844 and #840 — each fires the moment its review lands.

The blocker, exactly

Branch protection on main requires ≥1 approving review from an identity with write access other than the PR author. The author identity (Amperstrand) is the only credential on the review lane's machine; GitHub forbids authors approving their own PRs, and both gh pr merge and gh pr merge --admin are refused with "At least 1 approving review is required by reviewers with write access." Cross-identity approval is this repo's documented governance (the @felixfelix-bot requests on #840/#728/#844).

There is no other blocker. Fragments, tests, dispositions, merge ordering and the auto-merge queue are all done; the post-merge tree is pre-verified (below).

What resolves it — exact steps, in order

  1. Approve #844 → queued squash fires → main gets the fix + fragment, #724 closes itself, the rig's cloud-lab lanes can build from scratch again.
  2. Approve #840 → squash fires → #834 closes itself.
  3. #728 finishes: one-line rebase onto the new main (the fence flips red→green — pre-proven on the simulated tree), then its own approving review.

Post-merge tree — pre-verified while waiting

Simulated full landing (sim-all = main c7dbd74b + all three heads, merged):

  • Zero merge conflicts across all three PRs.
  • Fence red→green: guard fails on current main (names the exact Dockerfile.client line), passes on the merged tree.
  • tollwallet full suite, -race -tags testenv: ok 45.4s.
  • merchant FULL suite: ok 373.8s — the first fully-clean run possible, since it needs both the overnight flake fixes (#718/#835/#836/#839/#842) and this queue.
  • changelog-assemble.py check: 17 fragments, no findings; fold --dry-run clean; check-toolchain-parity.py green.

Rig runs still outstanding (handoff: /tmp/opencode/release-week/rig-handoff-wave3.md, quoted here for durability)

  • Run A — docker compose build --no-cache client killer on post-#844 main; PASS = both images export, go-builder resolves golang:1.26.8-bookworm. Capture the parse-error control on pre-#844 main once for the record.
  • Run B — tests/cloud-lab/run-crash-injection.sh to completion on post-#840 main; PASS = the rel-793 acceptance (pending swap recovered + post-recovery payment 200). Exercises the dir-fsync journal paths across kill windows.
  • Caveat: ai-legion's docker-bridge DNS may need network: host (lane-local, not part of any fix).
  • Deliberately not attempted: true power-cut durability of fsync(dir) (kill ≠ power loss) — needs a power-controlled labgrid place or VM snapshot rollback.

Operational notes

  • /tmp user quota breaks go builds under lane contention — TMPDIR=$HOME/gotmp go test … works around it.
  • Upstream gonuts-tollgate v0.12.1 has zero fsync/Sync calls in non-test code (bbolt-only persistence): #840's dir-fsync error-return semantics are this repo's own contract, recorded on the #840 decision log (issuecomment-6101702010).
  • The recent remote branch deletions were the #851 conflict remediation, not hygiene drift — re-push heals.

Review trail: #843/#844 wave3 reviews, #843 close record, #840 merge-record, approval asks (issuecomments 6092350810, 6092351042, 6106661992, 6106665143, 6106786703).

Dominant language
Go
Stars
12
Forks
14
Avg merge
1d 5h
Merged PRs (30d)
240

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from OpenTollGate/tollgate-module-basic-go

All issues in OpenTollGate/tollgate-module-basic-go

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.