eints allows submitting strings with disallowed UTF8 characters
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 34/100
Research direction
Start by reading the linked strgen block at src/strgen/strgen_base.cpp:735-740 and the referenced commit to understand which UTF-8 characters OpenTTD rejects. Then trace how eints validates submitted strings and compare its behavior for U+200B; done means eints rejects disallowed characters before they cause a build failure.
Written by the indexing model from the issue text.
Description
Specifically, U+200B (zero-width space)
Results in build failure:
/home/runner/work/OpenTTD/OpenTTD/src/lang/japanese.txt:2405: FATAL: Unwanted UTF-8 character U+200B in sequence '{BLACK}道路の種類を変更/アップグレードします.Shiftは、コスト見積もりの作成/表示を切り替えます'
see https://github.com/OpenTTD/OpenTTD/commit/b721787c7fafbff040fbcaa188a9d5dd7557e26f
& associated block in strgen
- Dominant language
- Python
- Stars
- 6
- Forks
- 12
- Avg merge
- 34m
- Merged PRs (30d)
- 3
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from OpenTTD/eints
-
Difficulty 2/5 1-3 hours Newbie friendliness 51/100
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
Difficulty 1/5 Under an hour Newbie friendliness 25/100
-
[REQ] Filtering...Open
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Similar issues
-
component/fhir type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
OpenConceptLab/ocl_issues#3026 ·
-
ODS datetime imports reject fractional seconds and exports drop themPossibly taken @IlyaKhalafi claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
TauricResearch/TradingAgents#1693 ·
Maintainers usually reply within 2 days
-
requests support
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
UKGovernmentBEIS/inspect_ai#6537 ·
Maintainers usually reply within 1 day