Tweak "you are now/again/no longer" status messages

Open
#369 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
30/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
perl
Domain
cli

Research direction

Start by reviewing the status_messages branch and its comparison diff, since the issue already identifies work in progress there. Confirm the remaining MAPTYPE_* suppression and grouped status-message behavior, then verify that both unchecked checklist items are addressed.

Written by the indexing model from the issue text.

Description

discussion
  • add squelchStatuses config option to suppress messages about unwanted statuses, set a reasonable default
  • add squelchStatusesAgain option to suppress only "you are again" messages for certain statuses (such as overweight which is sent every time inventory changes)
  • squelch all MAPTYPE_* again messages - always happen due to how packets are sent after map changes
  • group messages when several statuses change - maybe only display it when all buffered incoming packets were processed, for example; we can have a sys option to disable this

Branch: https://github.com/OpenKore/openkore/tree/status_messages
Diff: https://github.com/OpenKore/openkore/compare/status_messages

Dominant language
Perl
Stars
1.5k
Forks
1.2k
Avg merge
11h
Merged PRs (30d)
110

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from OpenKore/openkore

All issues in OpenKore/openkore

Similar issues

More Perl issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.