fix(manner): show the real result of manner and mute packets

Open
#4,397 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

@baphomello is already working on this.

Since Nov 21, 2026.

  • #4398 by @baphomello — open

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
perl

Research direction

Read the manner_message and GM_silence handlers in ServerType0.pm and the packet definitions in kRO/Sakexe_0.pm, where the 014A value and the 014B flag byte are both registered as type while the handlers read $args->{flag}. Cross-check against rAthena's clif_manner_message and clif_GM_silence for the code meanings (0/3/4/5 and 1/0), then make the handlers branch on the byte actually sent. Done means the two 014A codes and the 014B mute/unmute print distinct messages in the log shown above. Note an open pull request (#4398) already targets this, so coordinate before starting.

Written by the indexing model from the issue text.

Description

Openkore version git

master e0db188cd (ctime:2026-11-21)

XKore Mode

XKore 3

RO Server Name

rAthena local (packet version 20260619, serverType kRO_RagexeRE_2021_11_03)

Link to RO server

https://github.com/rathena/rathena

Result

When a GM mutes a player, the muted player sees You have been: unmuted by <GM>.. Every ZC_ACK_GIVE_MANNER_POINT (014A) prints A manner point has been successfully aligned., whatever the result code is.

ServerType0.pm and kRO/Sakexe_0.pm name the byte of 014A and the flag byte of 014B (ZC_NOTIFY_MANNER_POINT_GIVEN) type. The handlers manner_message and GM_silence read $args->{flag}. flag is never set, so undef == 0 is true in manner_message and if ($args->{flag}) is false in GM_silence. The first branch always wins.

rAthena sends 014A with 3 (chat block by GM), 4 (anti-spam block) and 5 ("you got a good point"), and 014B with 1 for a mute and 0 for an unmute (clif_manner_message, clif_GM_silence). The client in RODecomp reads the 014A value as the result code.

Relevant Log Output

The LABCMD lines are chat commands that a local debug plugin sends. The account is GM (group 99) and mutes its own character. rAthena answers @mute <minutes> with 014A code 0, 014A code 5, then 014B with type 1 (mute) or 0 (unmute).

LABCMD> c @mute 0 KoreLabTeste
Received packet: 014A Handler: manner_message
A manner point has been successfully aligned.
Received packet: 014A Handler: manner_message
A manner point has been successfully aligned.
Received packet: 014B Handler: GM_silence
You have been: unmuted by KoreLabTeste.
LABCMD> c @mute 5 KoreLabTeste
Received packet: 014A Handler: manner_message
A manner point has been successfully aligned.
Received packet: 014A Handler: manner_message
A manner point has been successfully aligned.
You have been muted for 5 minutes
You are now: EFST_MUTED (Duration: 300s)
Received packet: 014B Handler: GM_silence
You have been: unmuted by KoreLabTeste.

The last line is wrong: the character was just muted. The second 014A has code 5 and should print You got a good point..

Expected Result

014A prints one message per code: 0 aligned, 3 chat block by GM, 4 anti-spam block, 5 good point. 014B with type 1 prints You have been: muted by <GM>..

How to Reproduce
  1. Connect to an rAthena server with a GM account and enter the game.
  2. Run c @mute 5 <your character name>.
  3. The console prints You have been: unmuted by <name>. after You have been muted for 5 minutes, and A manner point has been successfully aligned. twice.
Dominant language
Perl
Stars
1.5k
Forks
1.2k
Avg merge
11h
Merged PRs (30d)
110

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from OpenKore/openkore

All issues in OpenKore/openkore

Similar issues

More Perl issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.