Remove unused server types 1 - 22

Open
#359 2 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
perl
Domain
backend

Research direction

Start with servers.txt to determine whether server type 7 still needs a meaningful name, then search for checks comparing $masterServer->{serverType}. Review the branches handling serverType 0 and remove unused server types and redundant checks while preserving behavior for relevant types.

Written by the indexing model from the issue text.

Description

code cleaning priority: low

Rename type 7 appropriately if still relevant (servers.txt).

Also remove checks like $masterServer->{serverType} ==. Probably use the branches where it's equal to 0.

Dominant language
Perl
Stars
1.5k
Forks
1.2k
Avg merge
11h
Merged PRs (30d)
110

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from OpenKore/openkore

All issues in OpenKore/openkore

Similar issues

More Perl issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.