[kRO_ ServerTypes] Runaway dependency

Open
#1,060 3 comments 3 reactions 1 assignee View on GitHub

Maintainers usually reply within 1 day

@lututui is already working on this.

Since Sep 2, 2017.

Assessment

This issue has not been assessed yet.

Description

code cleaning discussion enhancement server: Private

The issue:

  1. Each kRO_RagexeRE servertype depends on the previous one.
  2. The earliest kRO_RagexeRE depends on a kRO_Sakexe which depends on the previous kRO_Sakexe.
  3. The earliest kRO_Sakexe depends on kRO_Sakexe_0 which depends on kRO.
  4. No servertype actually depends on kRO_RagexeRE_0.
  5. kRO_RagexeRE_0 depends on kRO_RagexeRE_2014_03_05b (which doesn't exist).

TLDR: it's just a mess.

  • Why does kRO_RagexeRE and kRO_Sakexe severtypes use the respective previous one as base and not kRO_RagexeRE_0 and kRO_Sakexe_0?
  • Why does kRO_RagexeRE_0 would ever use base kRO_RagexeRE_2014_03_05b?
  • Is kRO_RagexeRE_0 even necessary?

A better structure:

                                    ServerType0
                                        |
       ___________________________ kRO_Sakexe_0
       |                                |
kRO_RagexeRE_0                          |
       |                                |
kRO_RagexeRE_                      kRO_Sakexe_

This would allow for a massive code cleanup (there are a lot of duped functions, i.e. sendStoragePassword, and things like '0871' => undef would become unnecessary) without breaking almost nothing, if anything at all.

Dominant language
Perl
Stars
1.5k
Forks
1.2k
Avg merge
11h
Merged PRs (30d)
110

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from OpenKore/openkore

All issues in OpenKore/openkore

Similar issues

More Perl issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.