[kRO_ ServerTypes] Runaway dependency
Maintainers usually reply within 1 day
@lututui is already working on this.
Since Sep 2, 2017.
Assessment
This issue has not been assessed yet.
Description
The issue:
- Each kRO_RagexeRE servertype depends on the previous one.
- The earliest kRO_RagexeRE depends on a kRO_Sakexe which depends on the previous kRO_Sakexe.
- The earliest kRO_Sakexe depends on kRO_Sakexe_0 which depends on kRO.
- No servertype actually depends on kRO_RagexeRE_0.
- kRO_RagexeRE_0 depends on kRO_RagexeRE_2014_03_05b (which doesn't exist).
TLDR: it's just a mess.
- Why does kRO_RagexeRE and kRO_Sakexe severtypes use the respective previous one as base and not kRO_RagexeRE_0 and kRO_Sakexe_0?
- Why does kRO_RagexeRE_0 would ever use base kRO_RagexeRE_2014_03_05b?
- Is kRO_RagexeRE_0 even necessary?
A better structure:
ServerType0
|
___________________________ kRO_Sakexe_0
| |
kRO_RagexeRE_0 |
| |
kRO_RagexeRE_ kRO_Sakexe_
This would allow for a massive code cleanup (there are a lot of duped functions, i.e. sendStoragePassword, and things like '0871' => undef would become unnecessary) without breaking almost nothing, if anything at all.
- Dominant language
- Perl
- Stars
- 1.5k
- Forks
- 1.2k
- Avg merge
- 11h
- Merged PRs (30d)
- 110
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from OpenKore/openkore
-
fix(char-create): show the real reason a character is refusedPossibly taken @baphomello claimed this 1 day ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
fix(manner): show the real result of manner and mute packetsPossibly taken @baphomello claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
Maintainers usually reply within 1 day
-
Intermittent undefined hook removal assertion during cleanupPossibly taken @baphomello claimed this today. Openbug
Difficulty 4/5 3-5 days Newbie friendliness 25/100
Maintainers usually reply within 1 day
-
fix(utils): skip repeated delimiters in parseArgsPossibly taken @baphomello claimed this 1 day ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 42/100
Maintainers usually reply within 1 day
-
fix(talknpc): bind server-started dialogs to the packet NPCPossibly taken @baphomello claimed this 2 days ago. Open
Difficulty 4/5 3-5 days Newbie friendliness 1/100
Maintainers usually reply within 1 day
All issues in OpenKore/openkore
Similar issues
-
Dev-output directory preparation accepts file-valued lib/include paths and fails on dangling linksOpenteam-cli
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
-
Difficulty 1/5 Under an hour Newbie friendliness 93/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
inverse-inc/packetfence#9728 ·
Maintainers usually reply within 1 day
-
area:cpan-port bug
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
fglock/PerlOnJava#2153 ·
Maintainers usually reply within 1 day