Follow-ups left open by the CCX / neutral-sensing work (#431, #432)
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Active
- Domain
- backend, performance
Research direction
This issue lists four independent follow-ups: inspect src/kestrel/kestrel_halbb_glue.c:193, src/chanmig/ChannelScore.cpp, examples/tx/main.cpp, or the MediaTek busy-path code around mt7612u_ch_time() and GetChannelBusy(). Start with the section for the task you choose; the scoring and TX-path work require the stated failure-matrix/on-air validation or lockstep harness, while MediaTek work requires controlled polling measurements. Done means completing one scoped follow-up with its specified validation, not taking on the whole list.
Written by the indexing model from the issue text.
Description
#431 landed the CCX pair (clm busy-airtime + nhm_env) and #432 landed the
vendor-neutral ChannelBusy contract plus src/sensing/. Both stopped short of
the same line on purpose: the new sensors are emitted, not scored, and two of
the five backends plus the whole MediaTek path are unmeasured. This is the
list of what was deliberately left out, so it stays visible instead of living in
merged PR descriptions.
Nothing here is urgent and nothing blocks anything. They are independent — take
one, or close this if the direction changes.
1. The MediaTek busy path is written but never measured
mt7612u_ch_time() reads MT_CH_BUSY (0x1134) / MT_CH_IDLE (0x1130) and
GetChannelBusy maps it, but there is no MT7612U on the bench, so
busy_airtime_measured ships false. Two things need measuring before that
flag flips:
- that
busy/(busy+idle)tracks real occupancy beyond repetition noise; - the real risk — that polling it at dwell cadence does not disturb
mt7612u_phy_tick()'s gain tracking. The accessor was deliberately narrowed
to those two registers to avoid the read-and-clear false-CCA field the AGC
loop owns, but "should not disturb it" is an argument, not a measurement.
Methodology: frame rate against a steady peer, with and without the poller,
and the no-tick control alongside — the tick's own favourable figure is
meaningless without it.
Also unmeasured on the Realtek side: Jaguar1 clm / nhm_env. Jaguar2 and
Jaguar3 are the two validated generations.
2. Kestrel discards clm_ratio it already computes
src/kestrel/kestrel_halbb_glue.c:193 drops clm_ratio, nhm_ratio and the
ifs_clm_* products the vendor env-monitor engine has already produced. That is
roughly three lines to un-discard — the reason busy_airtime_ok is currently
false on Kestrel is that NhmReader's maps are 11AC + JGR3 only, not that the
silicon lacks the facility. Worth doing on its own, before anything below
depends on it.
3. ChannelScore still ranks on a false-alarm proxy
src/chanmig/ChannelScore.cpp derives occupancy from fa_rate/(fa_rate+200) —
a proxy for busy airtime, now that real busy airtime exists as a number.
Rewiring it is not a refactor: it changes the migration law, so it needs its
own 14-row failure-matrix re-validation plus an on-air soak, and it should not
happen while clm is measured on only two of five generations.
Three caveats that must survive into whatever scoring law consumes these, all
from docs/rx-spectrum-sensing.md and none of them chip-specific:
- plain
fa_ofdmoutperformed both new sensors on every part measured — the
pair buys an airtime unit and a non-railing ratio, not a new detection; nhm_envis IGI-referenced, so it is blind wherever DIG is free to walk the
gain out from under it;- the ~2 ms window makes one dwell a sample, not a measurement (single-read
sd 4–24).chanscouttakes exactly one per dwell today; a naive one-shot
ranking across channels is the failure mode a neutral interface invites.
4. examples/tx still carries its own copy of the sense window
hopset_sense_window in examples/tx/main.cpp predates src/sensing/SenseWindow.h
and duplicates the same settle → barrier → observe → read discipline — its own
comment says so. SenseWindow was shaped to make this a mechanical drop-in, and
it would gain the counter-plausibility check tx has a flag for but never sets.
Left out of #432 because it is the TX hot path: it runs inside the slot-timed
hop loop holding g_hopset_mu across ingest, and its correctness criterion is
on-air FHSS lockstep, which headless tests cannot see. Anyone taking this needs
the lockstep harness, not just ctest.
- Dominant language
- C
- Stars
- 56
- Forks
- 29
- Avg merge
- 3h 43m
- Merged PRs (30d)
- 75
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from OpenIPC/devourer
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Follow-ups left open by the 8822B fast bandwidth toggle fix (#584)Possibly taken @josephnef claimed this today. Openenhancement
Difficulty 4/5 3-5 days Newbie friendliness 42/100
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 12/100
OpenIPC/devourer#579 · 1 comment ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 12/100
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 8/100
Maintainers usually reply within 1 day
All issues in OpenIPC/devourer
Similar issues
-
needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
389ds/389-ds-base#8157 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
coolsnowwolf/lede#14305 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Needs-Triage
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 2 days