Follow-ups left open by the CCX / neutral-sensing work (#431, #432)

Aperta
#433 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
25/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
c, cpp

Direzione di ricerca

This issue lists four independent follow-ups: inspect src/kestrel/kestrel_halbb_glue.c:193, src/chanmig/ChannelScore.cpp, examples/tx/main.cpp, or the MediaTek busy-path code around mt7612u_ch_time() and GetChannelBusy(). Start with the section for the task you choose; the scoring and TX-path work require the stated failure-matrix/on-air validation or lockstep harness, while MediaTek work requires controlled polling measurements. Done means completing one scoped follow-up with its specified validation, not taking on the whole list.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement

#431 landed the CCX pair (clm busy-airtime + nhm_env) and #432 landed the
vendor-neutral ChannelBusy contract plus src/sensing/. Both stopped short of
the same line on purpose: the new sensors are emitted, not scored, and two of
the five backends plus the whole MediaTek path are unmeasured.
This is the
list of what was deliberately left out, so it stays visible instead of living in
merged PR descriptions.

Nothing here is urgent and nothing blocks anything. They are independent — take
one, or close this if the direction changes.

1. The MediaTek busy path is written but never measured

mt7612u_ch_time() reads MT_CH_BUSY (0x1134) / MT_CH_IDLE (0x1130) and
GetChannelBusy maps it, but there is no MT7612U on the bench, so
busy_airtime_measured ships false. Two things need measuring before that
flag flips:

  • that busy/(busy+idle) tracks real occupancy beyond repetition noise;
  • the real risk — that polling it at dwell cadence does not disturb
    mt7612u_phy_tick()'s gain tracking. The accessor was deliberately narrowed
    to those two registers to avoid the read-and-clear false-CCA field the AGC
    loop owns, but "should not disturb it" is an argument, not a measurement.
    Methodology: frame rate against a steady peer, with and without the poller,
    and the no-tick control alongside — the tick's own favourable figure is
    meaningless without it.

Also unmeasured on the Realtek side: Jaguar1 clm / nhm_env. Jaguar2 and
Jaguar3 are the two validated generations.

2. Kestrel discards clm_ratio it already computes

src/kestrel/kestrel_halbb_glue.c:193 drops clm_ratio, nhm_ratio and the
ifs_clm_* products the vendor env-monitor engine has already produced. That is
roughly three lines to un-discard — the reason busy_airtime_ok is currently
false on Kestrel is that NhmReader's maps are 11AC + JGR3 only, not that the
silicon lacks the facility. Worth doing on its own, before anything below
depends on it.

3. ChannelScore still ranks on a false-alarm proxy

src/chanmig/ChannelScore.cpp derives occupancy from fa_rate/(fa_rate+200) —
a proxy for busy airtime, now that real busy airtime exists as a number.
Rewiring it is not a refactor: it changes the migration law, so it needs its
own 14-row failure-matrix re-validation plus an on-air soak, and it should not
happen while clm is measured on only two of five generations.

Three caveats that must survive into whatever scoring law consumes these, all
from docs/rx-spectrum-sensing.md and none of them chip-specific:

  • plain fa_ofdm outperformed both new sensors on every part measured — the
    pair buys an airtime unit and a non-railing ratio, not a new detection;
  • nhm_env is IGI-referenced, so it is blind wherever DIG is free to walk the
    gain out from under it;
  • the ~2 ms window makes one dwell a sample, not a measurement (single-read
    sd 4–24). chanscout takes exactly one per dwell today; a naive one-shot
    ranking across channels is the failure mode a neutral interface invites.
4. examples/tx still carries its own copy of the sense window

hopset_sense_window in examples/tx/main.cpp predates src/sensing/SenseWindow.h
and duplicates the same settle → barrier → observe → read discipline — its own
comment says so. SenseWindow was shaped to make this a mechanical drop-in, and
it would gain the counter-plausibility check tx has a flag for but never sets.

Left out of #432 because it is the TX hot path: it runs inside the slot-timed
hop loop holding g_hopset_mu across ingest, and its correctness criterion is
on-air FHSS lockstep, which headless tests cannot see. Anyone taking this needs
the lockstep harness, not just ctest.

Lingua principale
C
Stelle
56
Fork
29
Merge medio
3h 43m
PR unite (30g)
75

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di OpenIPC/devourer

Tutte le issue di OpenIPC/devourer

Issue simili

Altre issue su C

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.