Gate caller-side signal consumers on physt/PhyStsFill (follow-ups from #409)
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- c
- Domain
- networking
Research direction
Read the cited consumer sites in examples/rx/main.cpp and examples/chanscout/main.cpp, plus src/cell/UeRxAttribution.h:97; use RxQualityAccumulator’s snr_valid and per-metric sample counts as the reference. First check how physt and PhyStsFill expose parse presence, then exercise aggregated traffic with SetAmpduMode on the TX side. Done means absent PHY measurements no longer bias aggregates, per-UE windows, or rx.txhit encoding fields, with validation covering those cases.
Written by the indexing model from the issue text.
Description
PR #409 gave the library layer an honest per-frame PHY-status story: RxAtrib.physt is the raw descriptor bit on every generation that decodes it, the parse outcome is a PhyStsFill tier, and the library-internal EMAs (_rxq, _rxpaths, _cfo) fold only fields the parser actually claims. The caller-side consumers were left for follow-up, and they still ingest the deterministic zeros that physt=0 A-MPDU subframes now carry (pre-#409 those were random stale bytes; post-#409 they are a systematic bias toward zero):
examples/rx/main.cppsignal consumers are ungated (:911-913hopset per-slot accumulators,:920-925g_rxaggenergy/LinkHealth aggregate,:1136-1146DEVOURER_RX_ALLPATHSrx.pathrows). Under aggregated traffic the per-dwell RSSI/SNR means scale down with aggregation depth andsnr_minpins to 0, so the FHSS exclusion policy scores a better (more-aggregating) channel as worse,DEVOURER_LINKHEALTHclassifies a strong link as weak, and all-zerorx.pathvectors inflate measured inter-chain correlation toward 1.0 in antenna-decorrelation runs. The gate is now one field read away.rx.txhitcannot distinguish "no report" from BCC (examples/rx/main.cpp:1076).ldpc/stbc/bwcome only from the PHY-status parse, so a physt=0 subframe deterministically reportsldpc=0/stbc=0— indistinguishable from a real BCC fallback in encoding-truth-table runs (A-MPDU is opt-in in txdemo, so defaultregress.pyruns are unaffected). Either emitphystin the event or omitldpc/stbcwhen there was no report.examples/chanscout/main.cpphas the same ungated accumulator shape (:83-110):snr_sum/snr_minfold zeros from frames that carried no SNR, biasing survey records on channels with CCK or aggregated traffic.cell::UeRxAttributionfoldssnr_rawunconditionally (src/cell/UeRxAttribution.h:97): per-UE SNR windows inherit the same zero-dilutionRxQualityAccumulatorwas cured of in #409 (snr_minpins to 0, means drag down). Same fix shape: per-metric presence counts.
The last two are the same defect class #409 fixed in RxQualityAccumulator (an SNR sum whose zeros are absence, not measurements) — the fix there (snr_valid + per-metric sample counts) is the template.
Validation note for whoever picks this up: the demo-side bias needs aggregated traffic to show (SetAmpduMode on the TX side); a default regress run will not exercise it.
- Dominant language
- C
- Stars
- 56
- Forks
- 29
- Avg merge
- 3h 43m
- Merged PRs (30d)
- 75
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from OpenIPC/devourer
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Follow-ups left open by the 8822B fast bandwidth toggle fix (#584)Possibly taken @josephnef claimed this today. Openenhancement
Difficulty 4/5 3-5 days Newbie friendliness 42/100
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 12/100
OpenIPC/devourer#579 · 1 comment ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 12/100
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 8/100
Maintainers usually reply within 1 day
All issues in OpenIPC/devourer
Similar issues
-
needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
389ds/389-ds-base#8157 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
coolsnowwolf/lede#14305 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Needs-Triage
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 2 days