Gate caller-side signal consumers on physt/PhyStsFill (follow-ups from #409)

未关闭
#418 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
45/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
c
领域
networking

调研方向

Read the cited consumer sites in examples/rx/main.cpp and examples/chanscout/main.cpp, plus src/cell/UeRxAttribution.h:97; use RxQualityAccumulator’s snr_valid and per-metric sample counts as the reference. First check how physt and PhyStsFill expose parse presence, then exercise aggregated traffic with SetAmpduMode on the TX side. Done means absent PHY measurements no longer bias aggregates, per-UE windows, or rx.txhit encoding fields, with validation covering those cases.

由索引模型根据 Issue 内容生成。

描述

PR #409 gave the library layer an honest per-frame PHY-status story: RxAtrib.physt is the raw descriptor bit on every generation that decodes it, the parse outcome is a PhyStsFill tier, and the library-internal EMAs (_rxq, _rxpaths, _cfo) fold only fields the parser actually claims. The caller-side consumers were left for follow-up, and they still ingest the deterministic zeros that physt=0 A-MPDU subframes now carry (pre-#409 those were random stale bytes; post-#409 they are a systematic bias toward zero):

  • examples/rx/main.cpp signal consumers are ungated (:911-913 hopset per-slot accumulators, :920-925 g_rxagg energy/LinkHealth aggregate, :1136-1146 DEVOURER_RX_ALLPATHS rx.path rows). Under aggregated traffic the per-dwell RSSI/SNR means scale down with aggregation depth and snr_min pins to 0, so the FHSS exclusion policy scores a better (more-aggregating) channel as worse, DEVOURER_LINKHEALTH classifies a strong link as weak, and all-zero rx.path vectors inflate measured inter-chain correlation toward 1.0 in antenna-decorrelation runs. The gate is now one field read away.
  • rx.txhit cannot distinguish "no report" from BCC (examples/rx/main.cpp:1076). ldpc/stbc/bw come only from the PHY-status parse, so a physt=0 subframe deterministically reports ldpc=0/stbc=0 — indistinguishable from a real BCC fallback in encoding-truth-table runs (A-MPDU is opt-in in txdemo, so default regress.py runs are unaffected). Either emit physt in the event or omit ldpc/stbc when there was no report.
  • examples/chanscout/main.cpp has the same ungated accumulator shape (:83-110): snr_sum/snr_min fold zeros from frames that carried no SNR, biasing survey records on channels with CCK or aggregated traffic.
  • cell::UeRxAttribution folds snr_raw unconditionally (src/cell/UeRxAttribution.h:97): per-UE SNR windows inherit the same zero-dilution RxQualityAccumulator was cured of in #409 (snr_min pins to 0, means drag down). Same fix shape: per-metric presence counts.

The last two are the same defect class #409 fixed in RxQualityAccumulator (an SNR sum whose zeros are absence, not measurements) — the fix there (snr_valid + per-metric sample counts) is the template.

Validation note for whoever picks this up: the demo-side bias needs aggregated traffic to show (SetAmpduMode on the TX side); a default regress run will not exercise it.

主要语言
C
星标
56
派生
29
平均合并
3 小时 43 分钟
30 天内合并 PR
75

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

OpenIPC/devourer 的其他 Issue

查看 OpenIPC/devourer 的全部 Issue

相似的 Issue

更多 C Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。