Upgrade googletest to v1.16.0, the last release supporting C++14

Open
#418 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
50/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Active
Tech stack
cmake, cpp, github-actions

Research direction

Start by reading verification/CMakePresets.json and verification/cmake/modules/Findgtest.cmake, then inspect the submodules/googletest pin and its current revision. Move it to v1.16.0, add the stated C++14 compatibility comment, and run all 40 verification presets in ghcr.io/opencyphal/toolshed:ts26.4.5; done means every workflow passes while the C++14 flavours still compile with C++14.

Written by the indexing model from the issue text.

Description

build and test C++ dependencies

Summary

Upgrade the submodules/googletest pin from v1.15.2 to v1.16.0, and make it the last googletest upgrade while Nunavut verifies C++14 output.

Why this is the last one

googletest v1.17.0 and later require C++17:

Release README
v1.15.2 (current) "The 1.15.x branch requires at least C++14."
v1.16.0 "The 1.16.x branch requires at least C++14."
v1.17.0 "The 1.17.x branch requires at least C++17."
v1.18.0 "requires at least C++17"

The cpp-14 and cetl-14-17 verification flavours compile gtest tests as C++14 (test_serialization, test_bitarray, test_compiles, test_large_bitset, test_unionant, test_unionant_c++14, test_constant, and for cetl-14-17 also test_array_cetl++14-17 and test_unionant_pmr). With googletest 1.17 or newer, those flavours would have to compile their tests as C++17, and Nunavut would no longer verify its C++14 output natively. Only the arm-none-eabi test_armv7m build, which doesn't use gtest, would still compile it as C++14.

v1.16.0 is the newest googletest that still supports C++14. There is no later 1.16.x patch release.

Work

  1. Move submodules/googletest to the v1.16.0 tag.
  2. Run every verification workflow (verification/CMakePresets.json, all 40, in ghcr.io/opencyphal/toolshed:ts26.4.5) and fix any regressions.
  3. Add a comment next to the googletest submodule, or in verification/cmake/modules/Findgtest.cmake, saying that 1.16.x is the last C++14-compatible line and must not be upgraded past it while the C++14 flavours exist.

Later

Moving past v1.16.x depends on a separate decision: dropping C++14 verification, or verifying C++14 without gtest.

Dominant language
Python
Stars
48
Forks
26
Avg merge
1d 18h
Merged PRs (30d)
9

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from OpenCyphal/nunavut

All issues in OpenCyphal/nunavut

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.