Upgrade googletest to v1.16.0, the last release supporting C++14

Aperta
#418 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
50/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
cmake, cpp, github-actions

Direzione di ricerca

Start by reading verification/CMakePresets.json and verification/cmake/modules/Findgtest.cmake, then inspect the submodules/googletest pin and its current revision. Move it to v1.16.0, add the stated C++14 compatibility comment, and run all 40 verification presets in ghcr.io/opencyphal/toolshed:ts26.4.5; done means every workflow passes while the C++14 flavours still compile with C++14.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

build and test C++ dependencies

Summary

Upgrade the submodules/googletest pin from v1.15.2 to v1.16.0, and make it the last googletest upgrade while Nunavut verifies C++14 output.

Why this is the last one

googletest v1.17.0 and later require C++17:

Release README
v1.15.2 (current) "The 1.15.x branch requires at least C++14."
v1.16.0 "The 1.16.x branch requires at least C++14."
v1.17.0 "The 1.17.x branch requires at least C++17."
v1.18.0 "requires at least C++17"

The cpp-14 and cetl-14-17 verification flavours compile gtest tests as C++14 (test_serialization, test_bitarray, test_compiles, test_large_bitset, test_unionant, test_unionant_c++14, test_constant, and for cetl-14-17 also test_array_cetl++14-17 and test_unionant_pmr). With googletest 1.17 or newer, those flavours would have to compile their tests as C++17, and Nunavut would no longer verify its C++14 output natively. Only the arm-none-eabi test_armv7m build, which doesn't use gtest, would still compile it as C++14.

v1.16.0 is the newest googletest that still supports C++14. There is no later 1.16.x patch release.

Work

  1. Move submodules/googletest to the v1.16.0 tag.
  2. Run every verification workflow (verification/CMakePresets.json, all 40, in ghcr.io/opencyphal/toolshed:ts26.4.5) and fix any regressions.
  3. Add a comment next to the googletest submodule, or in verification/cmake/modules/Findgtest.cmake, saying that 1.16.x is the last C++14-compatible line and must not be upgraded past it while the C++14 flavours exist.

Later

Moving past v1.16.x depends on a separate decision: dropping C++14 verification, or verifying C++14 without gtest.

Lingua principale
Python
Stelle
48
Fork
26
Merge medio
1g 18h
PR unite (30g)
9

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di OpenCyphal/nunavut

Tutte le issue di OpenCyphal/nunavut

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.