Use CHAR_BIT instead of hard-coded literal 8 in generated C code

Open
#233 50 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp, python
Domain
build-system

Research direction

Start by reading the linked libcanard discussion and tracing where Nunavut's generated C code uses the literal 8. Identify the generator templates and relevant tests from that search. Done means generated code uses CHAR_BIT where required and the tests cover targets where CHAR_BIT differs from 8.

Written by the indexing model from the issue text.

Description

feature

It complicates the usage of Nunavut-generated code with those odd (DSP) platforms where CHAR_BIT != 8. See details at https://github.com/UAVCAN/libcanard/issues/184#issuecomment-1008287418

Dominant language
Python
Stars
48
Forks
26
Avg merge
1d 18h
Merged PRs (30d)
9

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from OpenCyphal/nunavut

All issues in OpenCyphal/nunavut

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.