Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Harden BLE pairing and actually revoke removed phones

Open
  • Is something wrong?
#9 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
34/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
rust
Domain
embedded-iot, security

Research direction

Read boards/esp/src/lib.rs:80 and the bond management and disconnect handling in ble/transport.rs, especially around line 521; trace how BondStore and the controller lists are updated. The issue identifies several separate security behaviors, including phone revocation, normal disconnect handling, and bond limits. Done means removed phones can no longer connect and ordinary disconnects do not erase bonds; pairing limits and the separate issue linked for Just Works pairing also need review.

Written by the indexing model from the issue text.

Description

  • Revocation doesn't work. On ESP, RemovePairedPhone / ClearPairedPhones
    (boards/esp/src/lib.rs:80) only edit the in-memory PAIRED_PHONES list,
    which nothing on ESP uses for authorization. The real credentials (LTKs in
    BondStore flash plus the controller filter-accept/resolving lists) are
    untouched, so a removed phone still connects. Remove the bond via
    stack.remove_bond_information, BondStore::remove_bond and
    remove_bond_from_controller (all exist in ble/transport.rs), and drop the
    separate registry or make it the source of truth.
  • Just Works pairing and the boot-time window on buttonless boards: https://github.com/OpenCarControls/firmware/issues/18.
  • Auto-heal is too aggressive. ble/transport.rs:521 treats
    REMOTE_USER_TERMINATED_CONN (a normal phone disconnect) as a security
    failure, so any disconnect during the pairing window wipes that phone's bond.
  • max_bonded_phones isn't enforced on BLE bonds (the store is hard-capped at 8).
  • Later: LTKs are stored unencrypted in flash (flash encryption).
Dominant language
Rust
Stars
1
Forks
0
Avg merge
13h 37m
Merged PRs (30d)
8

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

  • No Dockerfile or Docker Compose file
  • No pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from OpenCarControls/firmware

All issues in OpenCarControls/firmware

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.