Reject basic commands from MQTT until they're authenticated
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
Start in core-interface/src/dispatch.rs and trace how basic commands are dispatched from MQTT versus BLE. Check the linked contracts#8 and firmware#16 work for the authentication contract and removal condition; update the relevant docs. Done when MQTT basic commands are rejected with a clear status until firmware#16 is complete, and the docs explain the gate.
Written by the indexing model from the issue text.
Description
Basic commands are accepted from MQTT as well as BLE (core-interface/src/dispatch.rs). Today every E-GMP command returns "Not implemented", so that's harmless. Once real commands land, anyone with the broker credentials (extractable from the APK) could unlock the car or replay a captured command.
Until MQTT commands are authenticated (contracts#8), reject basic commands that arrive over MQTT with a clear status, and say so in the docs. Remove the gate once firmware#16 is done.
- Dominant language
- Rust
- Stars
- 1
- Forks
- 0
- Avg merge
- 13h 37m
- Merged PRs (30d)
- 8
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from OpenCarControls/firmware
-
Refresh stale docsOpen
Difficulty 1/5 1-3 hours Newbie friendliness 67/100
OpenCarControls/firmware#35 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
OpenCarControls/firmware#34 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
OpenCarControls/firmware#31 ·
Maintainers usually reply within 1 day
-
good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
OpenCarControls/firmware#30 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 68/100
OpenCarControls/firmware#57 ·
Maintainers usually reply within 1 day
All issues in OpenCarControls/firmware
Similar issues
-
documentation priority:p2 type:chore
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
facebookincubator/scrut#60 ·
-
dispatch:sol-high documentation
Difficulty 1/5 1-3 hours Newbie friendliness 85/100
carrick-sh/carrick#768 · 1 comment ·
Maintainers usually reply within 1 day
-
correctness postgres tursopg
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
tursodatabase/turso#10442 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
ankitects/anki#5864 · 1 reaction ·
Maintainers usually reply within 2 days