Make clippy fail CI on warnings and pass workflow inputs through env
Maintainers usually reply within 1 day
A pull request for this has already been merged.
- #59 by @Tichael — merged
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 74/100
Research direction
Read .github/workflows/ci.yml around lines 34 and 211, then find the xtask builders' clippy implementation; compare how each Clippy command handles arguments and warnings. Read auto-release.yml around lines 49–50 and check how workflow inputs reach the shell. Done when Clippy warnings fail CI in both paths and release inputs are passed through env:.
Written by the indexing model from the issue text.
Description
cargo clippy --package xtask(ci.yml:34) andcargo xtask clippy
(ci.yml:211) run without-D warnings, so lints never fail CI. Add
-- -D warnings(in the xtask builders'clippytoo).auto-release.yml:49-50interpolatesworkflow_dispatchinputs directly
into the shell; pass them throughenv:instead.
- Dominant language
- Rust
- Stars
- 1
- Forks
- 0
- Avg merge
- 10h 56m
- Merged PRs (30d)
- 15
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from OpenCarControls/firmware
-
Clean up E-GMP leftoversPossibly taken @Tichael claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
OpenCarControls/firmware#34 ·
Maintainers usually reply within 1 day
-
BLE: send the current state when the app subscribesPossibly taken @Tichael claimed this today. Open
Difficulty 3/5 1-2 days Newbie friendliness 35/100
OpenCarControls/firmware#58 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 35/100
OpenCarControls/firmware#55 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 35/100
OpenCarControls/firmware#54 ·
Maintainers usually reply within 1 day
-
First-setup pairing window is too short and stays open after the first bondPossibly taken A pull request linked to this issue is open or already merged. Openenhancement
Difficulty 4/5 3-5 days Newbie friendliness 55/100
OpenCarControls/firmware#53 ·
Maintainers usually reply within 1 day
All issues in OpenCarControls/firmware
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
IngvarConsulting/unica#2006 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
limitlessprojects/Go-Hybrid#1377 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
Docker host resolution missing default rootless Docker pathPossibly taken @500B claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
testcontainers/testcontainers-rs#1000 ·
Maintainers usually reply within 3 days
-
documentation
Difficulty 1/5 Under an hour Newbie friendliness 85/100
andyintheshell/perseid#73 ·
Maintainers usually reply within 1 day