LSP type inlay hint prefers initializer type over inherited redefinition typing

Open
#2,196 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

@devin-ai-integration is already working on this.

Since Nov 16, 2026.

  • #2333 by @devin-ai-integration — open

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
go, vscode
Domain
devtools

Research direction

Start with inferredType in internal/workspace/model/editor_facts.go, which calls sem.ExprResultType before sem.DeclaredFeatureTypes, so the string literal's String type wins over the inherited Label typing. Reproduce with the Example package in the issue via an inlay-hint request for the whole document. Done when the hint after redefines name reflects the inherited Label typing or clearly separates the initializer type from the feature's effective type, with a test covering that case.

Written by the indexing model from the issue text.

Description

bug
What happened, and what I expected instead

For an attribute that redefines a feature typed by a custom String subtype, the language server displays : String with tooltip inferred type ScalarValues::String. This looks like the type of the feature, but it is the type of the initializer expression and omits the more specific typing inherited through the redefinition.

Expected: the hint should account for the inherited Label typing, or clearly distinguish the initializer's expression type from the feature's effective typing. This report concerns the misleading inlay hint; it does not claim that the underlying semantic model loses the inherited typing or that assignment compatibility is necessarily validated incorrectly.

Reproduction

Open this standalone model and enable inferred-type inlay hints:

package Example {
    attribute def Label :> ScalarValues::String;
    attribute def Record {
        attribute name : Label;
    }
    attribute example : Record {
        attribute redefines name = "example";
    }
}

The hint after redefines name is : String, rather than reflecting the inherited Label typing.

Independently reproduced against sysml-lsp v0.12.1 using a fresh stdio LSP process with -no-record-cache: send initialize, initialized, textDocument/didOpen with the model above, and textDocument/inlayHint for the whole document. No model file needs to be written.

The server published an empty diagnostic list and returned:

[
  {
    "position": { "line": 6, "character": 32 },
    "label": ": String",
    "kind": 1,
    "tooltip": "inferred type ScalarValues::String",
    "paddingLeft": true
  }
]
Suspected cause

In internal/workspace/model/editor_facts.go, inferredType first calls sem.ExprResultType(scope, usage.Value) and only consults sem.DeclaredFeatureTypes(sym) if that returns nil. A string literal therefore supplies String before inherited/redefined feature typing can inform the hint.

Source checked at the installed extension's commit:
https://github.com/Open-MBEE/OpenSysML/blob/ddc5b7a632/internal/workspace/model/editor_facts.go

Version

Original editor observation: VS Code extension open-mbee.opensysml-sysml, version 0.12.2-nightly-20261109-ddc5b7a632.

Independent LSP reproduction:

sysml-lsp v0.12.1
  Commit:     b2f0e9b802a334369da94312c35cefbd8726d3bf
  Build time: 2026-11-06_03:25:57
  Go version: go1.27.3
Surface

Language server (sysml-lsp) / VS Code extension

Platform

Linux, VS Code Remote environment.

Dominant language
Go
Stars
59
Forks
20
Avg merge
10h 23m
Merged PRs (30d)
897

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Open-MBEE/OpenSysML

All issues in Open-MBEE/OpenSysML

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.