LSP type inlay hint prefers initializer type over inherited redefinition typing

Abierto
#2,196 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@devin-ai-integration ya está trabajando en esto.

Desde el 16/11/2026.

  • #2333 de @devin-ai-integration — abierto

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
45/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
go, vscode
Área
devtools

Línea de trabajo

Start with inferredType in internal/workspace/model/editor_facts.go, which calls sem.ExprResultType before sem.DeclaredFeatureTypes, so the string literal's String type wins over the inherited Label typing. Reproduce with the Example package in the issue via an inlay-hint request for the whole document. Done when the hint after redefines name reflects the inherited Label typing or clearly separates the initializer type from the feature's effective type, with a test covering that case.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug
What happened, and what I expected instead

For an attribute that redefines a feature typed by a custom String subtype, the language server displays : String with tooltip inferred type ScalarValues::String. This looks like the type of the feature, but it is the type of the initializer expression and omits the more specific typing inherited through the redefinition.

Expected: the hint should account for the inherited Label typing, or clearly distinguish the initializer's expression type from the feature's effective typing. This report concerns the misleading inlay hint; it does not claim that the underlying semantic model loses the inherited typing or that assignment compatibility is necessarily validated incorrectly.

Reproduction

Open this standalone model and enable inferred-type inlay hints:

package Example {
    attribute def Label :> ScalarValues::String;
    attribute def Record {
        attribute name : Label;
    }
    attribute example : Record {
        attribute redefines name = "example";
    }
}

The hint after redefines name is : String, rather than reflecting the inherited Label typing.

Independently reproduced against sysml-lsp v0.12.1 using a fresh stdio LSP process with -no-record-cache: send initialize, initialized, textDocument/didOpen with the model above, and textDocument/inlayHint for the whole document. No model file needs to be written.

The server published an empty diagnostic list and returned:

[
  {
    "position": { "line": 6, "character": 32 },
    "label": ": String",
    "kind": 1,
    "tooltip": "inferred type ScalarValues::String",
    "paddingLeft": true
  }
]
Suspected cause

In internal/workspace/model/editor_facts.go, inferredType first calls sem.ExprResultType(scope, usage.Value) and only consults sem.DeclaredFeatureTypes(sym) if that returns nil. A string literal therefore supplies String before inherited/redefined feature typing can inform the hint.

Source checked at the installed extension's commit:
https://github.com/Open-MBEE/OpenSysML/blob/ddc5b7a632/internal/workspace/model/editor_facts.go

Version

Original editor observation: VS Code extension open-mbee.opensysml-sysml, version 0.12.2-nightly-20261109-ddc5b7a632.

Independent LSP reproduction:

sysml-lsp v0.12.1
  Commit:     b2f0e9b802a334369da94312c35cefbd8726d3bf
  Build time: 2026-11-06_03:25:57
  Go version: go1.27.3
Surface

Language server (sysml-lsp) / VS Code extension

Platform

Linux, VS Code Remote environment.

Lenguaje dominante
Go
Estrellas
59
Forks
20
Merge medio
10 h 23 min
PR fusionados (30 d)
897

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Open-MBEE/OpenSysML

Todos los issues de Open-MBEE/OpenSysML

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.