Issaquah (Feb 2023) P2630 LEWG feedback

Open
#334 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp

Research direction

Start with the linked feedback in papers issue 1293 and the wording for the “submdspan function” mentioned here. Review the proposed feature-test macro, the strided_slice aggregate wording, the sub_map definition, and the integral-constant-like requirement; done means the two polled changes and the related wording issues are resolved in the paper.

Written by the indexing model from the issue text.

Description

Customization point design does matter even for experts, because there are performance implications.

Add a new feature test macro (don't just bump the number of the old one).

LWG has a different way to say "strided_slice is an aggregate type." See my comment below for the words of power.

In the wording for "submdspan function," we lost the definition of sub_map (the result of submdspan_mapping). Also, we probably shouldn't call the result of submdspan_mapping "sub_map_offset"?

Do we want to permit anything with a value member that's a constant expression, not just integral_constant? Just need exposition-only concept or trait. Has a constexpr static value data member. "static-integral-constant-like" etc.

Polled changes:

  1. Add [a new] feature test macro
  2. Relax requirements to "integral constant like"

Link to feedback: https://github.com/cplusplus/papers/issues/1293

Dominant language
HTML
Stars
29
Forks
26
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ORNL/cpp-proposals-pub

All issues in ORNL/cpp-proposals-pub

Similar issues

More Backend & API Design issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.