web_responsive overhaul feeler
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 15/100
- Issue type
- Refactor
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- javascript, scss
- Domain
- frontend
Research direction
The issue discusses web_responsive, web_dark_mode (#3324), web_quick_start_screen, app menu structure, and sticky list and form headers, but names no files or tests. Read the discussion in #2684 and this issue’s comments to find whether maintainers agreed on a direction and which changes remain in scope. Done would require an agreed plan for the overhaul, target branch, and PR split; the payload does not specify an implementation task.
Written by the indexing model from the issue text.
Description
While working on trying to make my web_dark_mode work with web_responsive I have realized that it may be time for a bit of an overhaul.
However, before spending any time doing so I'd like to get the consensus of the users and maintainers of this module to see what I should and shouldn't do. Here are the main points:
Lack of Direction
Two themes for the app screen as well as 3 different search modes. I have read all the discussion on #2684 where this was introduced and feel like there should have been an agreement reached before going forward rather than just keeping all options. The two themes, especially, make implementing dark mode confusing and inconvenient.
As far as search modes go, my personal preference would be odoo command palette, but keep the search bar. I could possibly modify the css to line it up with the search bar in order to seem more coherent. In any case, I would not get rid of the search bar as it is the only thing allowing searches from mobile.
Getting rid of these options would also eliminate the need for the little drop icon in the navbar. If we cannot agree on a single mode + theme, I would like to also suggest moving this to the user preferences section as I don't see any real reason for it to be in the navbar.
Outdated Code
In 18.0 list view headers are sticky by default and in 19.0 form status bars are sticky too. Maybe other features too?
File Structure
Not really a big thing, but the file structure does not follow web. primary_varables.scss for instance are tucked away in a legacy folder. Also, everything to do with the home menu would be under webclient and probably not split between apps_menu and apps_menu_item. If there are no objections, I would like to reorganize this.
Redirect to Home
I like this feature, but it seems a bit out of place. Could it be incorporated into web_quick_start_screen? I would also like to add a little home button to the navbar and could have sworn that I have actually seen that done already somewhere. Anyway, not really the subject of this issue.
Lastly, the big question: should I start these modifications on 19.0 of 18.0 and would you prefer it be broken up into multiple PRs, or just one?
Thank you all!
- Dominant language
- JavaScript
- Stars
- 1.2k
- Forks
- 2.2k
- Avg merge
- 3d 15h
- Merged PRs (30d)
- 30
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from OCA/web
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
[19.0] web_timeline: ValueError "Invalid field 'date_start:month'" when grouping by a date fieldPossibly taken @stferraro claimed this today. Openbug
Difficulty 3/5 1-2 days Newbie friendliness 25/100
Maintainers usually reply within 1 day
-
[19.0] web_m2x_options: system parameter + m2o options not working properly when no recordsPossibly taken @CristhianAC claimed this 11 days ago. Openbug
Difficulty 3/5 1-2 days Newbie friendliness 58/100
Maintainers usually reply within 1 day
-
Migration to version 20.0Possibly taken A pull request linked to this issue is open or already merged. Openhelp wanted no stale work in progress
Difficulty 4/5 3-5 days Newbie friendliness 45/100
Maintainers usually reply within 1 day
-
enhancement
Difficulty 4/5 1-2 days Newbie friendliness 45/100
Maintainers usually reply within 1 day
Similar issues
-
bug package:workers-shared
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
cloudflare/workers-sdk#16924 · 1 comment ·
Maintainers usually reply within 1 day
-
dashboard
Difficulty 2/5 Half a day Newbie friendliness 78/100
damodharg6/payledger#9 ·
-
parse: child keys like `007`, `1e3`, `0x1f`, `-1` make the parent an empty array and hide the valueOpen
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
area/mobile area/ui good first issue
Difficulty 1/5 Under an hour Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
natemoo-re/ultrahtml#102 ·