web_responsive overhaul feeler
メンテナーはふだん 1 日以内に返信
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 15/100
- issue の種類
- リファクタリング
- 明瞭さ
- 説明が足りない
- 活発さ
- 停滞
- 技術スタック
- javascript, scss
- 領域
- frontend
調査の方向性
The issue discusses web_responsive, web_dark_mode (#3324), web_quick_start_screen, app menu structure, and sticky list and form headers, but names no files or tests. Read the discussion in #2684 and this issue’s comments to find whether maintainers agreed on a direction and which changes remain in scope. Done would require an agreed plan for the overhaul, target branch, and PR split; the payload does not specify an implementation task.
索引モデルが issue の本文から書いたものです。
説明
While working on trying to make my web_dark_mode work with web_responsive I have realized that it may be time for a bit of an overhaul.
However, before spending any time doing so I'd like to get the consensus of the users and maintainers of this module to see what I should and shouldn't do. Here are the main points:
Lack of Direction
Two themes for the app screen as well as 3 different search modes. I have read all the discussion on #2684 where this was introduced and feel like there should have been an agreement reached before going forward rather than just keeping all options. The two themes, especially, make implementing dark mode confusing and inconvenient.
As far as search modes go, my personal preference would be odoo command palette, but keep the search bar. I could possibly modify the css to line it up with the search bar in order to seem more coherent. In any case, I would not get rid of the search bar as it is the only thing allowing searches from mobile.
Getting rid of these options would also eliminate the need for the little drop icon in the navbar. If we cannot agree on a single mode + theme, I would like to also suggest moving this to the user preferences section as I don't see any real reason for it to be in the navbar.
Outdated Code
In 18.0 list view headers are sticky by default and in 19.0 form status bars are sticky too. Maybe other features too?
File Structure
Not really a big thing, but the file structure does not follow web. primary_varables.scss for instance are tucked away in a legacy folder. Also, everything to do with the home menu would be under webclient and probably not split between apps_menu and apps_menu_item. If there are no objections, I would like to reorganize this.
Redirect to Home
I like this feature, but it seems a bit out of place. Could it be incorporated into web_quick_start_screen? I would also like to add a little home button to the navbar and could have sworn that I have actually seen that done already somewhere. Anyway, not really the subject of this issue.
Lastly, the big question: should I start these modifications on 19.0 of 18.0 and would you prefer it be broken up into multiple PRs, or just one?
Thank you all!
- 主要言語
- JavaScript
- スター
- 1.2k
- フォーク
- 2.2k
- 平均マージ
- 3日 15時間
- マージ済み PR(30日)
- 22
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
OCA/web のほかの issue
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 62/100
メンテナーはふだん 1 日以内に返信
-
bug
難易度 3/5 1〜2日 初心者へのやさしさ 58/100
メンテナーはふだん 1 日以内に返信
-
Migration to version 20.0対応中かも このイシューにリンクされたプルリクエストがオープン中、またはマージ済みです。 オープンhelp wanted no stale work in progress
難易度 4/5 3〜5日 初心者へのやさしさ 45/100
メンテナーはふだん 1 日以内に返信
-
enhancement
難易度 4/5 1〜2日 初心者へのやさしさ 45/100
メンテナーはふだん 1 日以内に返信
-
enhancement
難易度 5/5 1週間以上 初心者へのやさしさ 20/100
メンテナーはふだん 1 日以内に返信
似ている issue
-
API: `tsc.exe` opens a visible console window on Windows when the parent process has no consoleオープン
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
microsoft/TypeScript#65083 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
openfoodfacts/open-prices-frontend#2496 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
メンテナーはふだん 1 日以内に返信
-
[metro-file-map] An error a watcher backend reports ends the server, since nothing listens for itオープン
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
メンテナーはふだん 2 日以内に返信
-
needs:triage
難易度 2/5 1〜3時間 初心者へのやさしさ 77/100
メンテナーはふだん 1 日以内に返信