[Engine] rocm-core 10.1-1 Default HIP compiler location needs to change

Open Beginner friendly
#6,071 2 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 4 days

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
75/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
cmake, cpp

Research direction

Start at setup.py:5163 and trace how the ROCm root and HIP compiler paths are passed into the build. Confirm the expected compiler location for rocm-core 10.1-1, then run the build on a ROCm setup to verify it finds clang++ at /opt/rocm/lib/llvm/bin/clang++.

Written by the indexing model from the issue text.

Description

Attempted to rebuild after updating to newest Strata and newest ROCm and it could not find the HIP compiler.

The default clang++ location has changed with rocm-core 10.1-1. It is now located at /opt/rocm/lib/llvm/bin/clang++.

After changing setup.py:5163 (added 'lib') to have f"-DCMAKE_HIP_COMPILER={root / 'lib' / 'llvm' / 'bin' / 'clang++'}", f"-DCMAKE_HIP_COMPILER_ROCM_ROOT={root}", the build succeeded.

VRAM: 7900XTX 24GB
RAM: 32GB DDR5-6000
Operating System: ArchLinux 7.3.4-arch1-2

Dominant language
C++
Stars
11.6k
Forks
1k
Avg merge
18d 13h
Merged PRs (30d)
4

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Niko1221/Strata

All issues in Niko1221/Strata

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.