[Engine] rocm-core 10.1-1 Default HIP compiler location needs to change
Maintainers usually reply within 4 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 75/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- cmake, cpp
- Domain
- backend, build-system
Research direction
Start at setup.py:5163 and trace how the ROCm root and HIP compiler paths are passed into the build. Confirm the expected compiler location for rocm-core 10.1-1, then run the build on a ROCm setup to verify it finds clang++ at /opt/rocm/lib/llvm/bin/clang++.
Written by the indexing model from the issue text.
Description
Attempted to rebuild after updating to newest Strata and newest ROCm and it could not find the HIP compiler.
The default clang++ location has changed with rocm-core 10.1-1. It is now located at /opt/rocm/lib/llvm/bin/clang++.
After changing setup.py:5163 (added 'lib') to have f"-DCMAKE_HIP_COMPILER={root / 'lib' / 'llvm' / 'bin' / 'clang++'}", f"-DCMAKE_HIP_COMPILER_ROCM_ROOT={root}", the build succeeded.
VRAM: 7900XTX 24GB
RAM: 32GB DDR5-6000
Operating System: ArchLinux 7.3.4-arch1-2
- Dominant language
- C++
- Stars
- 11.6k
- Forks
- 1k
- Avg merge
- 18d 13h
- Merged PRs (30d)
- 4
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Niko1221/Strata
-
needs-format
Difficulty 1/5 Under an hour Newbie friendliness 78/100
Niko1221/Strata#6040 · 1 comment ·
Maintainers usually reply within 4 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 4 days
-
[Engine] RTX 5090 32 GB, Q2_0: the ~13 KB/token KV figure measured, and why 1M context cannot start at --kv int8 (--kv-resident is the lever)Possibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Niko1221/Strata#5852 · 1 comment ·
Maintainers usually reply within 4 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 4 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
Maintainers usually reply within 4 days
Similar issues
-
Documentation: Fix parameter markup, legacy branch link, and phrasing in Detachable Joints and Model Command tutorialsPossibly taken @patelshivani2283-lab claimed this today. Open
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
KhronosGroup/Vulkan-Tutorial#551 ·
Maintainers usually reply within 1 day
-
pumpOpen
Difficulty 1/5 Under an hour Newbie friendliness 68/100
dewenni/ESP_Buderus_KM271#191 ·