[TUI] strata launch: moving the Access-step highlight makes an API key a local launch keeps

Open Beginner friendly
#5,812 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 4 days

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
80/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
python
Domain
cli

Research direction

Start with strata_cli/launch/screens.py at the Access screen's on_cursor() and commit() methods, then read the cursor actions that call on_cursor() and compare the key rule in strata_cli/cmd.py:437-440. Add or update terminal tests for moving the highlight and committing each access choice. Done means browsing options has no side effects and a local launch saves no API key.

Written by the indexing model from the issue text.

Description

Problem

On the strata launch Access step, pressing up/down to read the help text under each option runs a handler that makes an API key as soon as the highlight lands on any option beyond "This computer only". Nothing clears that key when the highlight goes back to "This computer only", so a launch that ends on localhost serves with a key - while the same screen says a key is not needed there.

strata_cli/launch/screens.py:1556 (Access screen):

def on_cursor(self) -> None:
    kind = self.menu().current.key
    s = self.ctx.settings
    s.access = kind
    if kind != "local" and not s.api_key and not s.no_key:
        s.api_key = acc.kept_key() or acc.new_key()

action_move calls on_cursor() on every cursor move (screens.py:192-197), and so do action_edge (:199-204) and paging. commit() (:1607-1611) only sets a key for a non-local choice; it never clears one for a local choice. The only ways off are t (key toggle) or --no-api-key (cmd.py:277-290).

The key then follows the launch: derive_config writes it into the run config regardless of the access choice (strata_cli/launch/runner.py:551-556, if s.api_key: cfg["api_key"] = s.api_key), it is stored in the private launch preset (settings.py:134 "stored only in the private preset file"), and kept_key() (access.py:320) hands it to later launches.

Environment

Strata Version: 0.2.13 (engine 0.1.59), Terminal installed over a fresh desktop-app install
OS: Windows, Linux, macOS - the handler is platform-independent; the report below is from Linux
Model/quant: Qwen 3.8 Flash Next, IQ3_S (native pack)

Reproduce

Reported from a real setup, exactly as the reporter worked:

  1. Fresh install. The desktop app downloads Qwen 3.8 Flash Next IQ3_S, tunes it, chatting works.
  2. Install the Terminal, run strata launch, and create a model preset.
  3. On the Access step, move the highlight between the choices in order to read the help text below them.
  4. Leave the highlight on "This computer only" and finish the launch.
  5. Quit, then serve that model with strata serve --profile <the profile the launch created>.
  6. Point a client (Pi) at the localhost address.

Expected

No key: the help text on that very screen says "Only programs on this computer can reach it, so no key is needed." (screens.py:1553) and "This computer only is the safe default and never needs a key" (:1496). Outside the TUI the rule is the one expected here - a key is made only when s.access != "local" (cmd.py:437-440).

Actual

The key made while browsing is kept, written into the run config and into the saved preset, and the server requires it. The client is refused:

{"error": {"type": "authentication_error", "message": "missing or wrong API key"}}

(serve/server.py:7867-7873; the server takes the key straight from the config: serve/server.py:10166-10176, strata_cli/cli.py:788-792.)

Secondary, same handler: on_cursor also assigns s.access = kind, so moving the highlight to read a description changes the pending choice. Reading the help text is not a read-only action.

Evidence

Function-level replay of the shipped logic (verbatim on_cursor + commit + the derive_config key lines, stubbed menu, fake key generator):

cursor moves s.access s.api_key after cfg["api_key"]
down to "Other computers" lan set -
down to Tailscale tailscale set -
up to "Other computers" lan set -
up to "This computer only" local still set -
commit, then derive_config local set written into the run config

Nothing in tests/terminal exercises on_cursor, keytoggle or newkey (grep -rln "on_cursor\|keytoggle\|newkey" tests/terminal/*.py is empty), so no test locks this as intended behaviour.

Reproduction status: the user workflow above was reproduced by the reporter in normal use. The code path is additionally confirmed here by reading the 0.2.13 source and by the function-level replay above; the full TUI was not driven in this checkout (Textual is not installed in its test environment).

Suggested minimum fix

Make a key where the choice is acted on, not where the cursor rests: keep on_cursor to the help text, and let the TUI use the rule cmd.py:437-440 already uses - make a key only at commit, and only when s.access != "local". That also makes the local path byte-identical to strata launch --access local, which writes no key (runner.py:551-556).

Related

#4396 (closed) fixed a different route to the same visible symptom - strata launch silently minting a new API key through kept_key() when a profile file could not be read. Different cause, same user-visible failure; this thread is about the Access screen's cursor handler.

Dominant language
C++
Stars
11.6k
Forks
1k
Avg merge
18d 13h
Merged PRs (30d)
4

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Niko1221/Strata

All issues in Niko1221/Strata

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.