strata_bench.py records a layer-split run as single-GPU (card list and VRAM total)
Maintainers usually reply within 3 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 91/100
Research direction
Start at tools/strata_bench.py:614-616 and inspect how static["gpu_name"] is matched against the locally used cards. Reproduce with the described two-GPU layer-split configuration and ./bench.sh --url http://127.0.0.1:<port>. Done means the generated README.md and results.json retain both served GPU names and report the combined 40952 MiB, while single-card cases remain unchanged.
Written by the indexing model from the issue text.
Description
What happened
A benchmark of a two-card layer split (RTX 3090 + RTX 4080 SUPER) produces a report naming only the first card:
"gpu": ["NVIDIA GeForce RTX 3090"], "gpu_vram_mib": 24576
while the server reports both correctly:
"machine": {"gpu": {"name": "NVIDIA GeForce RTX 3090 + NVIDIA GeForce RTX 4080 SUPER",
"total_mib": 40952}}
and the engine log says layer split: layers 0-28 (CUDA0), 29-47 (CUDA1), one hand-off per window.
Cause, tools/strata_bench.py:614-616:
elif len(used) > 1 and static.get("gpu_name"):
named = [g for g in used if g["name"] == static["gpu_name"]]
used = named[:1] or used[:1]
With a split, static["gpu_name"] is "A + B", so no single card equals it, named is empty, and used is truncated to the first card. gpu_vram_mib is then summed over that one card (lines 627-628), overriding the server's correct total. The " + " form is already parsed 20 lines below (#2001), but that branch only fires when the served cards are not all local (the other-vendor case), so a split across two local NVIDIA cards never reaches it.
The branch is only reached when cfg is None, i.e. with --url. On current main that is the only way to benchmark at all, because bench.sh crashes when it starts the server itself (#2872). So at the moment every layer-split run benchmarked with the tool is reported as single-GPU, in both the card list and the VRAM total.
To reproduce: a config with "gpu": [0, 1], start the server, then ./bench.sh --url http://127.0.0.1:<port>. The generated README.md and results.json name one card.
Suggested fix: match each name the server gives, keeping the count.
elif len(used) > 1 and static.get("gpu_name"):
served_names = [n for n in static["gpu_name"].split(" + ") if n and n != "?"]
named = [g for g in used if g["name"] in served_names]
used = named[:len(served_names)] or used[:1]
Checked against this machine's values: the split case becomes ["RTX 3090", "RTX 4080 SUPER"] / 40952 MiB, and both single-card-of-two cases are unchanged.
Strata version, GPU, OS
Engine 0.1.45, main at 477ac13c (these lines unchanged on main today). RTX 3090 + RTX 4080 SUPER, Linux (Ubuntu 24.04 base), engine compiled from source.
- Dominant language
- C++
- Stars
- 11.6k
- Forks
- 1k
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Niko1221/Strata
-
[Other] error detected in the compilation of Strata/src/qwen35/q36_engine.cuPossibly taken A pull request linked to this issue is open or already merged. Openneeds-format
Difficulty 2/5 1-3 hours Newbie friendliness 69/100
Niko1221/Strata#3368 · 1 comment ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-2 days Newbie friendliness 75/100
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Niko1221/Strata#3269 · 2 comments ·
Maintainers usually reply within 3 days
-
Difficulty 1/5 Under an hour Newbie friendliness 64/100
Niko1221/Strata#3197 · 3 comments ·
Maintainers usually reply within 3 days
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
eclipse-score/inc_someip_gateway#356 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
HarperFast/rocksdb-js#945 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
design good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
scribe-org/Scribe-Android#739 ·
Maintainers usually reply within 1 day