Themes: list the fixed UI numbers that no theme key controls

Open Beginner friendly
#2,039 3 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
70/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Active
Tech stack
rust

Research direction

Start in crates/ui/src/egui_app/ and sweep the draw code for numeric literals and colour constants (sizes, gaps, Color32 values), noting file and line for each. Compare what you find against the keys already present in assets/themes/theme.json.example and the key-set test so you only list numbers no theme key covers. Done means the list is posted as a comment here, with each entry marked as must-become-a-key or not; the must-become ones then need their own issue or a new key in the example file with the key-set test green.

Written by the indexing model from the issue text.

Description

area:ui effort:low enhancement P7 source:agent

Found during the work on #2025 (PR #2038). Item 5 of #2025 asks for a list of the fixed numbers in the UI code that are not theme settings. PR #2038 does not make that list.

What to do: read the UI draw code (crates/ui/src/egui_app/) for fixed sizes, gaps and colours that no theme key controls. Comment the list on this issue, with the file and the line of each. For each entry, say if it must become a theme key.

Done means: the list is in a comment on this issue. Each entry that must become a theme key has an issue of its own, or is added to assets/themes/theme.json.example with its key-set test green.

Dominant language
Rust
Stars
8
Forks
11
Avg merge
6h 45m
Merged PRs (30d)
905

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from NeoTech/Camcraft

All issues in NeoTech/Camcraft

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.