double counting of airflow?

Open
  • Is something wrong?
#431 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
ruby
Domain
analytics

Research direction

Start at measures/comstock_sensitivity_reports/measure.rb around line 1333 and trace how FCU and DOAS airflow contribute to the two total mass-flow values. Compare the calculation with the intended airflow accounting, then determine whether the same DOAS air is counted twice and document or correct the behavior if confirmed.

Written by the indexing model from the issue text.

Description

  • came across while working on something else
  • and unsure if it was intended
  • but isn't this below double counting? so for like FCU DOAS, FCU airflow gets added to the zone_hvac_total_mass_flow_kg_s and DOAS airflow gets added to the air_system_total_mass_flow_kg_s. but that air from DOAS goes to FCUs. so I felt like this might be double counting.

https://github.com/NREL/ComStock/blob/7198d82540d5c1131ccccb6739224a181f9b9f2d/measures/comstock_sensitivity_reports/measure.rb#L1333

Dominant language
Ruby
Stars
54
Forks
28
Avg merge
3d 23h
Merged PRs (30d)
5

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from NatLabRockies/ComStock

All issues in NatLabRockies/ComStock

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.