Test failures in create_bar_from_building_type_ratios

Open
  • Is something wrong?
#401 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
ruby
Domain
testing-qa

Research direction

Run ruby create_bar_from_building_type_ratios_test.rb -n test_building_shorter_than_neighbors in resources/create_bar_from_building_type_ratios and review the failures reported at create_bar_from_building_type_ratios_test.rb:59. Read the referenced logging.rb section to understand why the surface-area message is registered as an error under OS SDK 3.10.0. Done means the listed tests report Success without that error.

Written by the indexing model from the issue text.

Description

You have failing tests in resources/create_bar_from_building_type_ratios with OS SDK 3.10.0

log_messages_to_runner from standards registers an error.

eg: ruby create_bar_from_building_type_ratios_test.rb -n test_building_shorter_than_neighbors

"Initial area of other surface 'Surface 176' 297.209 does not equal post intersection area 297.203"

https://github.com/NREL/openstudio-standards/blob/72ab197f5f3f84eda2456efa44cee6e9d264176f/lib/openstudio-standards/utilities/logging.rb#L1-L37

  1) Failure:
CreateBarFromBuildingTypeRatiosTest#test_building_taller_than_neighbors [create_bar_from_building_type_ratios_test.rb:59]:
Expected: "Success"
  Actual: "Fail"

  2) Failure:
CreateBarFromBuildingTypeRatiosTest#test_t24_ofs [create_bar_from_building_type_ratios_test.rb:59]:
Expected: "Success"
  Actual: "Fail"

  3) Failure:
CreateBarFromBuildingTypeRatiosTest#test_neighboring_buildings [create_bar_from_building_type_ratios_test.rb:59]:
Expected: "Success"
  Actual: "Fail"

  4) Failure:
CreateBarFromBuildingTypeRatiosTest#test_building_shorter_than_neighbors [create_bar_from_building_type_ratios_test.rb:59]:
Expected: "Success"
  Actual: "Fail"

  5) Failure:
CreateBarFromBuildingTypeRatiosTest#test_rotation_45_party_wall_fraction [create_bar_from_building_type_ratios_test.rb:59]:
Expected: "Success"
  Actual: "Fail"
Dominant language
Ruby
Stars
54
Forks
28
Avg merge
3d 23h
Merged PRs (30d)
5

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from NatLabRockies/ComStock

All issues in NatLabRockies/ComStock

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.