Data dictionary in comstockpostproc

Open
#399 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
data

Research direction

Start with postprocessing/compare_upgrades.py and follow its call to export_data_and_enumeration_dictionary in postprocessing/comstockpostproc/comstock.py. Reproduce the traceback on the SDR 2025 R4 branch and inspect why output_dir is a dict when passed to os.path.join. Done means the postprocessing export completes without this TypeError.

Written by the indexing model from the issue text.

Description

I get the error message below when trying to run postproc on the current SDR branch (sdr 2025 r4):

Traceback (most recent call last):
File "C:\GitRepos\comstock_marley\postprocessing\compare_upgrades.py", line 113, in
main()
File "C:\GitRepos\comstock_marley\postprocessing\compare_upgrades.py", line 109, in main
comstock.export_data_and_enumeration_dictionary()
File "C:\GitRepos\comstock_marley\postprocessing\comstockpostproc\comstock.py", line 3939, in export_data_and_enumeration_dictionary
file_path = os.path.abspath(os.path.join(self.output_dir, file_name))
File "C:\Users\aallen.conda\envs\comstockpostproc\lib\ntpath.py", line 104, in join
path = os.fspath(path)
TypeError: expected str, bytes or os.PathLike object, not dict

Dominant language
Ruby
Stars
54
Forks
28
Avg merge
3d 23h
Merged PRs (30d)
5

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from NatLabRockies/ComStock

All issues in NatLabRockies/ComStock

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.