Remove nested measure calls

Open
  • Is something wrong?
#372 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
38/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
ruby
Domain
tooling

Research direction

Review PR 361 and the upgrade measures that call other measures to identify the nested calls and their current arguments. Then inspect the postprocessing or buildstockbatch applicability flow. Done means measure code no longer makes nested measure calls and applicability is handled in the appropriate surrounding flow.

Written by the indexing model from the issue text.

Description

upgrade measure

Some upgrade measures are calling other upgrade measures within their code. This poses a challenge for maintainability and clutters measure arguments with non-measure relevant inputs.

This was added in PR and should be undone.

Adjust postprocessing or buildstockbatch to adjust measure applicability, rather than handling it in the measure.

Dominant language
Ruby
Stars
54
Forks
28
Avg merge
3d 23h
Merged PRs (30d)
5

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from NatLabRockies/ComStock

All issues in NatLabRockies/ComStock

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.