FacDB - foodbankny_foodbanks has a new program_type with no factype

Open Beginner friendly
#2,847 0 comments 0 reactions 1 assignee View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
64/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
sql

Research direction

Read facdb/sql/pipelines/foodbankny_foodbanks.sql and find the CASE that maps program_type to factype, plus the existing filter that drops SENIOR rows, to see both patterns. Confirm the three listed rows against the 20261027 archive before changing anything. Then rebuild and run the not_null tests on factype (facdb_base, facdb_classification, facdb_export); done means a build on the latest archive no longer emits NULL factype. Note the map-or-filter choice needs a maintainer decision first.

Written by the indexing model from the issue text.

Description

db-facilities

The 20261027 archive of foodbankny_foodbanks has a new program_type value, Healthcare Partner, on 3 rows. facdb/sql/pipelines/foodbankny_foodbanks.sql maps program_type to factype with a CASE that only knows pantry and soup kitchen values, so these rows come through with a NULL factype and fail the not_null tests on factype (facdb_base, facdb_classification, facdb_export).

facname
The Table At The Family Support Center : Family Health Centers at NYU Langone
Metro Community Health Center, Inc. : MCHC Food Pantry Program
Community Healthcare Network : Community Healthcare Network

The decision is whether these belong in FacDB and, if so, which factype they get. Two of the three names say "Food Pantry", which suggests Food Pantry may be right, but that's a guess from the name. The other option is to filter them out the way SENIOR rows already are.

The value isn't in the main or nightly_qa build schemas, so any FacDB build against the latest archive will hit this. Found in the uv.lock upgrade build (#2844).

Dominant language
Python
Stars
2
Forks
0
Avg merge
13h 8m
Merged PRs (30d)
138

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from NYCPlanning/data-engineering

All issues in NYCPlanning/data-engineering

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.