FacDB - foodbankny_foodbanks has a new program_type with no factype
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 64/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- sql
- Domain
- data-engineering
Research direction
Read facdb/sql/pipelines/foodbankny_foodbanks.sql and find the CASE that maps program_type to factype, plus the existing filter that drops SENIOR rows, to see both patterns. Confirm the three listed rows against the 20261027 archive before changing anything. Then rebuild and run the not_null tests on factype (facdb_base, facdb_classification, facdb_export); done means a build on the latest archive no longer emits NULL factype. Note the map-or-filter choice needs a maintainer decision first.
Written by the indexing model from the issue text.
Description
The 20261027 archive of foodbankny_foodbanks has a new program_type value, Healthcare Partner, on 3 rows. facdb/sql/pipelines/foodbankny_foodbanks.sql maps program_type to factype with a CASE that only knows pantry and soup kitchen values, so these rows come through with a NULL factype and fail the not_null tests on factype (facdb_base, facdb_classification, facdb_export).
| facname |
|---|
| The Table At The Family Support Center : Family Health Centers at NYU Langone |
| Metro Community Health Center, Inc. : MCHC Food Pantry Program |
| Community Healthcare Network : Community Healthcare Network |
The decision is whether these belong in FacDB and, if so, which factype they get. Two of the three names say "Food Pantry", which suggests Food Pantry may be right, but that's a guess from the name. The other option is to filter them out the way SENIOR rows already are.
The value isn't in the main or nightly_qa build schemas, so any FacDB build against the latest archive will hit this. Found in the uv.lock upgrade build (#2844).
- Dominant language
- Python
- Stars
- 2
- Forks
- 0
- Avg merge
- 13h 8m
- Merged PRs (30d)
- 138
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from NYCPlanning/data-engineering
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
NYCPlanning/data-engineering#2996 ·
Maintainers usually reply within 1 day
-
db-knownprojects
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
NYCPlanning/data-engineering#2629 ·
Maintainers usually reply within 1 day
-
CSCL - coincident_seg_count double-counts subway/rail crossingsPossibly taken @alexrichey claimed this today. Opendb-cscl
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
NYCPlanning/data-engineering#2616 · 1 assignee ·
Maintainers usually reply within 1 day
-
db-gft
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
NYCPlanning/data-engineering#2532 ·
Maintainers usually reply within 1 day
-
ingest
Difficulty 3/5 1-2 days Newbie friendliness 18/100
NYCPlanning/data-engineering#2995 ·
Maintainers usually reply within 1 day
All issues in NYCPlanning/data-engineering
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
pearu/agent-sandbox#451 ·
Maintainers usually reply within 1 day
-
run_gate loads a custom tasks file from outside the working directoryPossibly taken @Ru0k3 claimed this today. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
MakazhanAlpamys/Soup#3189 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
Maintainers usually reply within 1 day