Drop aFONLL support, support FFNS

Open
#122 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Read src/pineko/evolve.py around the linked lines 133–139 and src/pineko/check.py around lines 161–163 to locate the aFONLL branches. The issue proposes removing those branches once everyone has migrated to nFONLL and supporting a single FONLL implementation. Check the surrounding code and tests to identify remaining aFONLL paths; done means those paths are removed and FFNS is supported.

Written by the indexing model from the issue text.

Description

enhancement good first issue physics

As soon as everyone migrated to nFONLL we should remove all the branching with aFONLL, and just support a single FONLL implementation.

E.g. the following should only keep the if branch
https://github.com/NNPDF/pineko/blob/3f3c887e5c91a5728e0790ef6d32933cc7e5b0ba/src/pineko/evolve.py#L133-L139
and this should be removed
https://github.com/NNPDF/pineko/blob/3f3c887e5c91a5728e0790ef6d32933cc7e5b0ba/src/pineko/check.py#L161-L163

Dominant language
Python
Stars
2
Forks
0
Avg merge
10d 34m
Merged PRs (30d)
3

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from NNPDF/pineko

All issues in NNPDF/pineko

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.