Drop aFONLL support, support FFNS
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 25/100
Research direction
Read src/pineko/evolve.py around the linked lines 133–139 and src/pineko/check.py around lines 161–163 to locate the aFONLL branches. The issue proposes removing those branches once everyone has migrated to nFONLL and supporting a single FONLL implementation. Check the surrounding code and tests to identify remaining aFONLL paths; done means those paths are removed and FFNS is supported.
Written by the indexing model from the issue text.
Description
As soon as everyone migrated to nFONLL we should remove all the branching with aFONLL, and just support a single FONLL implementation.
E.g. the following should only keep the if branch
https://github.com/NNPDF/pineko/blob/3f3c887e5c91a5728e0790ef6d32933cc7e5b0ba/src/pineko/evolve.py#L133-L139
and this should be removed
https://github.com/NNPDF/pineko/blob/3f3c887e5c91a5728e0790ef6d32933cc7e5b0ba/src/pineko/check.py#L161-L163
- Dominant language
- Python
- Stars
- 2
- Forks
- 0
- Avg merge
- 10d 34m
- Merged PRs (30d)
- 3
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from NNPDF/pineko
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
-
Overwrite if encounters stale symlinks to ekosPossibly taken @ashishsoni-ai claimed this 5 days ago. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
benchmarks/unit tests
Difficulty 1/5 Under an hour Newbie friendliness 78/100
-
Difficulty 4/5 3-5 days Newbie friendliness 20/100
-
Check whether IC from theory card is usedMay be free again @kamillaurent claimed this 58 days ago, and no pull request is open. Open
Similar issues
-
opensubtitlescom: provider rejects pt-PT even though its own converter maps itPossibly taken @paulo-0308 claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Diaoul/subliminal#1405 ·
-
Internal ErrorOpenbug
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
frappe/frappe_docker#2071 ·
Maintainers usually reply within 1 day
-
bug python
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
traceloop/openllmetry#4717 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
The-Pocket/PocketFlow#161 ·
-
comp/desktop P2 type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
NousResearch/hermes-agent#157702 ·
Maintainers usually reply within 1 day