Overwrite if encounters stale symlinks to ekos
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 84/100
Research direction
Read inherit_ekos in src/pineko/theory.py and check how it handles existing paths and symlinks when --overwrite is unset. Reproduce the FileExistsError with a stale symlink, then verify the behavior for both overwrite settings; done when inheriting handles stale symlinks as described without breaking existing eko handling.
Written by the indexing model from the issue text.
Description
In inherit_ekos in src/pineko/theory.py, currently the program crashes if a stale symlink is found for an eko when attempting to inherit. If the tag --overwrite is not set, the program crashes. We could automatically overwrite the bad symlink if this happens.
Could do something like
if new.exists() or new.is_symlink():
if not self.overwrite:
rich.print(f"Skipping existing eko {new}")
continue
new.unlink()
instead of crashing with a FileExistsError.
- Dominant language
- Python
- Stars
- 2
- Forks
- 0
- Avg merge
- 10d 34m
- Merged PRs (30d)
- 3
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from NNPDF/pineko
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
-
benchmarks/unit tests
Difficulty 1/5 Under an hour Newbie friendliness 78/100
-
Difficulty 4/5 3-5 days Newbie friendliness 20/100
-
Check whether IC from theory card is usedMay be free again @kamillaurent claimed this 58 days ago, and no pull request is open. Open
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 46/100
Similar issues
-
opensubtitlescom: provider rejects pt-PT even though its own converter maps itPossibly taken @paulo-0308 claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Diaoul/subliminal#1405 ·
-
Internal ErrorOpenbug
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
frappe/frappe_docker#2071 ·
Maintainers usually reply within 1 day
-
bug python
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
traceloop/openllmetry#4717 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
The-Pocket/PocketFlow#161 ·
-
comp/desktop P2 type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
NousResearch/hermes-agent#157702 ·
Maintainers usually reply within 1 day