Add IRT (Iranian toman) and MLC (Cuba) to the currency catalogue
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 90/100
Research direction
Start with assets/data/fiat.json, which the issue identifies as the currency catalogue. Add the IRT and MLC entries in code order, then check that the catalogue remains sorted and run flutter test to verify the flag font test. Done when both currencies appear with their names and flags in the default currency and order pickers.
Written by the indexing model from the issue text.
Description
Context
The app's currency catalogue is assets/data/fiat.json (148 entries,
sorted by code; each has code, name and flag). It feeds:
- the currency picker on Create order (
currency_section.dart): the whole
catalogue when the node sets no currency limit, otherwise the catalogue
narrowed to the node's list, plus any code the node lists that the
catalogue lacks (shown with no name or flag); - the default currency in Settings (
currency_selector_dialog.dart), which
offers the catalogue only; - the flags shown next to a currency code (
currencyFlagsProvider).
Problem
Two currencies traded on Mostro are missing from the catalogue:
- MLC (Moneda Libremente Convertible), used in Cuba alongside CUP. The
v1 app (MostroP2P/mobile) lists it, andpayment_methods.jsonhere
already has its methods (Transfermovil, EnZona), butfiat.jsondoes not. - IRT (Iranian toman, 10 rials), the unit Iranians quote prices in.
OnlyIRR(rial) is listed.
So, on a node that sets no currency limit, neither can be chosen to create
an order, and neither can be set as the default currency. On a node that
lists them, they appear with no name or flag.
Proposed change
Add two entries to assets/data/fiat.json, in code order:
{ "code": "IRT", "name": "Iranian Toman", "flag": "🇮🇷" }
{ "code": "MLC", "name": "Freely Convertible Currency", "flag": "🇨🇺" }
No new payment methods: MLC already has its own, and IRT uses the
default list until someone provides Iranian ones.
Out of scope
- Payment methods for IRT.
- Whether a node publishes a rate for these codes (needed for market-price
orders); that is the node's price source, not the app.
Acceptance criteria
- MLC and IRT can be picked on Create order on a node with no currency
limit, and as the default currency in Settings, with their name and flag. - The catalogue stays sorted by code.
test/core/flag_font_test.dartstill passes (both flags already exist
for CUP and IRR).
Testing
flutter test(the flag font test readsfiat.json).- Manual: Settings → default currency → search "MLC" and "IRT"; Create
order → currency picker shows both with name and flag.
- Dominant language
- Dart
- Stars
- 11
- Forks
- 9
- Avg merge
- 18h 25m
- Merged PRs (30d)
- 194
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from MostroP2P/app
-
area: rust-core bug priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
area: ui
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
Similar issues
-
[Packages] [flutter_shaders] InkWell shader golden test fails on Flutter stable and Master channelsOpenfrom: manual-qa
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
README highlightsOpendocumentation
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
patarapolw/lingua_srs#22 ·
-
interruptRestart fails with "Tool <name> not found" for namespaced tools (ns/tool)Possibly taken @esrakadah claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
genkit-ai/genkit-dart#657 ·
Maintainers usually reply within 1 day
-
area/ci-build bug
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
DarkFlippers/qUnleashed#423 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100